-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highlighting in results #22
Comments
I think If we choose to do it in JavaScript then it comes to do post processing (after all search results are rendered). |
Yes, static links should be as close in functionality as possible, so we probably want to do this at the API / Go level, not JavaScript. |
@sylvinus for this I am thinking doing something like this,
This does not replaces map value but however,
Am i doing something wrong ? or you suggest this approach or something else ? |
This is a good start! You should really have a separate |
Having parts of the results which matched in bold is a great visual aid.
An open question is: should we highlight results from the API as well? Or is that left to the client (in that case, to our JavaScript as well) ?
The text was updated successfully, but these errors were encountered: