Skip to content

Commit

Permalink
BUG: Workaround publish_github_release upload issue using actions/upl…
Browse files Browse the repository at this point in the history
  • Loading branch information
jcfr committed Jan 27, 2022
1 parent 449038e commit e70f8b5
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 10 deletions.
27 changes: 17 additions & 10 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,21 @@ jobs:
ctest -LE XDisplayRequired -VV
- name: Publish packages
run: |
cd src
ci_addons publish_github_release commontk/applauncher \
--exit-success-if-missing-token \
--prerelease-packages ../build/CTKAppLauncher-*.tar.gz \
--prerelease-packages-clear-pattern "*macosx*" \
--prerelease-packages-keep-pattern "*<COMMIT_SHORT_SHA>*" \
--release-packages build/CTKAppLauncher-*.tar.gz
env:
GITHUB_TOKEN: secrets.COMMONTKBOT_GITHUB_TOKEN
uses: actions/upload-artifact@v2
with:
name: macos-packages
path: build/CTKAppLauncher-*.tar.gz

# See https://github.com/scikit-build/scikit-ci-addons/issues/96
#- name: Publish packages
# run: |
# cd src
# ci_addons publish_github_release commontk/applauncher \
# --exit-success-if-missing-token \
# --prerelease-packages ../build/CTKAppLauncher-*.tar.gz \
# --prerelease-packages-clear-pattern "*macosx*" \
# --prerelease-packages-keep-pattern "*<COMMIT_SHORT_SHA>*" \
# --release-packages build/CTKAppLauncher-*.tar.gz
# env:
# GITHUB_TOKEN: secrets.COMMONTKBOT_GITHUB_TOKEN

2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ maintainers: how to make a release ?
git push origin master
```

_**Important:** Until issue [scikit-build/scikit-ci-addons/issues/96](https://github.com/scikit-build/scikit-ci-addons/issues/96) is addressed, macOS release package should be manually downloaded from the GitHub Actions artifact and uploaded as a GitHub release asset._

6. Update `CMakeLists.txt` setting `CTKAppLauncher_VERSION_IS_RELEASE` to `0`

```bash
Expand Down

0 comments on commit e70f8b5

Please sign in to comment.