Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add API to select items in the DICOM browser #1002

Merged
merged 1 commit into from
Nov 4, 2021
Merged

ENH: Add API to select items in the DICOM browser #1002

merged 1 commit into from
Nov 4, 2021

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Nov 3, 2021

Allow selecting patient/study/series in the DICOM browser GUI.

This is can be used for example for highlighting new items after DICOM import.

@lassoan lassoan requested a review from pieper November 3, 2021 18:22
@lassoan lassoan self-assigned this Nov 3, 2021
pieper
pieper approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jcfr
jcfr requested changes Nov 3, 2021
View reviewed changes
Libs/DICOM/Widgets/ctkDICOMTableManager.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Widgets/ctkDICOMTableManager.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Widgets/ctkDICOMTableManager.cpp Outdated Show resolved Hide resolved
@jcfr
Copy link
Member

jcfr commented Nov 3, 2021

Consider rebasing the topic so that we avoid commit like Merge branch 'master' into add-dicombrowser-select-api making it hard to cherry-pick or revert changes.

@pieper
Copy link
Member

pieper commented Nov 3, 2021

@lassoan github reported this was out of date with master so I merged it and there are no conflicts but I wondered why you hadn't started from the master branch? Maybe better to rebase instead of squash as @jcfr suggests.

@lassoan
Copy link
Member Author

lassoan commented Nov 3, 2021

I wondered why you hadn't started from the master branch?

No specific reason, it was just what I had in my build tree.

Thanks for the review and comments, I'll rebase on latest master.

@lassoan lassoan force-pushed the add-dicombrowser-select-api branch 2 times, most recently from 4279893 to f4b9096 Compare November 3, 2021 21:07
@lassoan lassoan requested a review from jcfr November 3, 2021 21:08
jcfr
jcfr reviewed Nov 3, 2021
View reviewed changes
Libs/DICOM/Widgets/ctkDICOMBrowser.cpp Outdated Show resolved Hide resolved
Libs/DICOM/Widgets/ctkDICOMBrowser.cpp Outdated Show resolved Hide resolved
@lassoan lassoan requested a review from jcfr November 3, 2021 21:30
@lassoan @jcfr
ENH: Add API to select items in the DICOM browser
4bd6926 
This allows selecting patient/study/series in the DICOM browser GUI.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
@lassoan
Copy link
Member Author

lassoan commented Nov 4, 2021

@jcfr I've updated ctkDICOMTableView::setCurrentSelection to use d->tblDicomDatabaseView->selectionModel()->isSelected(index), because selection mode is "full row", so it is enough to check that the item in the first column is selected.

@lassoan
Copy link
Member Author

lassoan commented Nov 4, 2021

@jcfr Thanks for your comments, I addressed all of them, let me know if this is good to go now.

jcfr
jcfr approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating 🙏

Once this is integrated, I will then rebase and update #1005

@pieper pieper merged commit 402696a into commontk:master Nov 4, 2021
jcfr added a commit to jcfr/CTK that referenced this pull request Nov 4, 2021
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
9f11bca 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
@lassoan lassoan deleted the add-dicombrowser-select-api branch November 4, 2021 17:48
jcfr added a commit to jcfr/CTK that referenced this pull request Mar 3, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
d30390f 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit to jcfr/CTK that referenced this pull request Apr 13, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
209d469 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit to jcfr/CTK that referenced this pull request Apr 13, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
17ec2a4 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit to jcfr/CTK that referenced this pull request Apr 17, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
b812e50 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jamesobutler pushed a commit to jcfr/CTK that referenced this pull request Jun 3, 2023
@jcfr @jamesobutler
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
f6ec19f 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit to jcfr/CTK that referenced this pull request Jun 15, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
e77b8f6 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit to jcfr/CTK that referenced this pull request Jun 26, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
284aa8c 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit to jcfr/CTK that referenced this pull request Jul 11, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
f37ccdd 
This commit updates the implementation to account for changes introduced
in PR commontk#1002 (ENH: Add API to select items in the DICOM browser)
jcfr added a commit that referenced this pull request Jul 13, 2023
@jcfr
COMP: Fix Qt4/C++98 ctkDICOMBrowser and ctkDICOMTableView
89b5762 
This commit updates the implementation to account for changes introduced
in PR #1002 (ENH: Add API to select items in the DICOM browser)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr jcfr approved these changes

@pieper pieper pieper approved these changes

Assignees

@lassoan lassoan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lassoan @jcfr @pieper