ENH: Always compile python scripts as legacy .pyc files #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine the script introduced in commit db3f4d9 ("Re-create python compile script only if needed and fix dependency. See commontk#449", 2014-04-16) by explicitly specifying the `cfile` parameter. Disable the default behavior (introduced in Python 3.2) of generating .pyc files in the `__pycache__` directory, as outlined in PEP-3147. This improvement is needed for Slicer-based applications, enabling them to locate scripted modules and plugins as either .py or .pyc files in a specific directory. References: * PEP-3147: https://peps.python.org/pep-3147/ * Slicer Forum Discussion: https://discourse.slicer.org/t/how-to-hide-the-code-of-the-script-module/26135/14 * Python Documentation: https://docs.python.org/3/library/py_compile.html#py_compile.compile
|
Thanks for the review. @jamesobutler @lassoan Any suggestions before we move forward with the integration? |
jamesobutler
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
The old legacy location of pyc files is fine with me.
I’ve been doing a compile step in my Slicer extension CMakeLists along with specifying the .pyc versions to include in the package.
execute_process(COMMAND ${Python3_EXECUTABLE} -c "import compileall;compileall.compile_dir('${CMAKE_CURRENT_SOURCE_DIR}', legacy=True, optimize=2, force=True)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the script introduced in commit db3f4d9 ("Re-create python compile script only if needed and fix dependency. See #449", 2014-04-16) by explicitly specifying the
cfileparameter. Disable the default behavior (introduced in Python 3.2) of generating .pyc files in the__pycache__directory, as outlined in PEP-3147.This improvement is needed for Slicer-based applications, enabling them to locate scripted modules and plugins as either .py or .pyc files in a specific directory.
References: