Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libs/DICOM: Fix warning and build errors #860

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Libs/DICOM: Fix warning and build errors #860

merged 3 commits into from
Apr 15, 2019

Commits on Apr 15, 2019

  1. COMP: Fix invalid initialization of non-const reference 

    This commit fixes the following error:

  error: invalid initialization of non-const reference of type ‘DcmTagKey&’ from an rvalue of type ‘DcmTagKey
    @jcfr
    jcfr committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    97bafa3 View commit details
    Browse the repository at this point in the history

  2. COMP: Fix unused-parameter warnings in ctkDICOMDisplayedFieldGenerato… 

    …rRadiotherapySeriesDescriptionRule

This commit fixes warnings like the following:

  /path/to/Slicer-SuperBuild/CTK/Libs/DICOM/Core/ctkDICOMDisplayedFieldGeneratorDefaultRule.cpp:72:26: warning: unused parameter ‘emptyFieldsDisplayStudies’ [-Wunused-parameter]
   QMap<QString, QString> emptyFieldsDisplayStudies,
                          ^
    @jcfr
    jcfr committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    521bb09 View commit details
    Browse the repository at this point in the history

  3. COMP: Fix -Wdelete-non-virtual-dtor in ctkDICOMDisplayedFieldGenerato… 

    …rAbstractRule

This commit fixes the following warning:

  /path/to/Slicer-SuperBuild/CTK/Libs/DICOM/Core/ctkDICOMDisplayedFieldGenerator.cpp: In destructor ‘virtual ctkDICOMDisplayedFieldGeneratorPrivate::~ctkDICOMDisplayedFieldGeneratorPrivate()’:
  /path/to/Slicer-SuperBuild/CTK/Libs/DICOM/Core/ctkDICOMDisplayedFieldGenerator.cpp:62:12: warning: deleting object of abstract class type ‘ctkDICOMDisplayedFieldGeneratorAbstractRule’ which has non-virtual destructor will cause undefined behaviour [-Wdelete-non-virtual-dtor]
       delete rule;
              ^
    @jcfr
    jcfr committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    fa757e1 View commit details
    Browse the repository at this point in the history