Fix PythonLibs handling #874
Conversation
|
Fixed a wrong iterator name I introduced in a last-minute change. |
|
This PR still is not complete, sorry. I just run into a debug linker problem on Windows with CTKScriptingPythonCore for the first time. Eventhough python37_d.lib is set as link dependency something wants to draw in python37.lib. Investigating... |
In fact, when linking against python37.lib instead of python37d.lib, everything works fine. |
|
Thank you for working on this, I don't fully understand the details but it's great if you fix such inconsistencies. Note that we often need to use release-mode Python binaries in applications built in debug-mode because third-party binary packages are only available for release-mode Python. Please make sure that this will remain possible. |
No worries, last fix in the pull request is actually right what you describe: prefer using release-mode Python also in debug configuration as debug-mode Python has many implications. Seems to be the adopted standard in other Projects like Qt and Boost as well. |
The FindPythonLibs module reads PYTHON_LIBRARY as a hint but it also sets the same variable when successful. In the latter case, the variable may be set to a list containing target_link_libraries keywords like "optimized" and "debug" instead of a single filepath. When read as a hint, though, FindPythonLibs only understands a single filepath. Repeated unguarded calls to the module may result in a faulty value of PYTHON_LIBRARY like: "optimized;optimized;optimized;python3.lib;debug;debug;python3d.lib" Such values entail errors when the linker tries to link against the keywords "optimized" or "debug". This commit implements the following changes: * Fix usage of FindPythonLibs result variables The documented output variable of FindPythonLibs is PYTHON_LIBRARIES instead of PYTHON_LIBRARY, which is an old relict from pre CMake 3.0 (minimal required CMake version of CTK). * Fix linking to Python on Windows in Debug configuration Linking to a debug version of Python has many implications and is generally quirky enough that many famous projects like Boost and Qt decided to link against the release version of Python instead. Handling of PYTHON_LIBRARIES/PYTHON_LIBRARY was refactored into ctkFunctionExtractOptimizedLibrary. For non-MSVC/non-multiconfig build systems it is basically a NO-OP and does not change behavior. Signed-off-by: Stefan Dinkelacker <s.dinkelacker@dkfz-heidelberg.de>
jcfr
force-pushed
the
fix-pythonlibs-handling
branch
from
e4db29f
to
ff1800e
Compare
keywords like "optimized" and "debug" instead of a single filepath. When read as a hint, though, FindPythonLibs only understands a single filepath. Repeated unguarded calls to the module may result in a faulty value of PYTHON_LIBRARY like "optimized;optimized;python3.lib;debug;debug;python3d.lib". Such values entail errors when the linker tries to link against the keywords "optimized" or "debug".