Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: typo in database, signal not emitted #896

Merged
merged 1 commit into from
Dec 6, 2019
Merged

BUG: typo in database, signal not emitted #896

merged 1 commit into from
Dec 6, 2019

Conversation

issakomi
Copy link
Contributor

@issakomi issakomi commented Dec 6, 2019

I guess it is a right fix, isn't it?

lassoan
lassoan approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you.

@lassoan lassoan merged commit 78341ab into commontk:master Dec 6, 2019
@issakomi issakomi deleted the typo_db_signal branch December 7, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issakomi @lassoan