Skip to content

Integrate upstream change  #3

Closed
@jcfr

Description

@jcfr

The text reported below has been sent by Florian Link from Mesvis lab after he integrated the CTK contributions:

- Renamed set/enableRedirectStdInCallBack to set/enableRedirectStdInCallback 
(since other methods use Callback spelling)
See https://github.com/commontk/CTK/issues/156
EDIT: DONE

- Removed VTK wrapping from PythonQt
EDIT: DONE

- Removed VTK wrapping from PythonQtConversion
EDIT: DONE

- Removed VTK from CMake filelist
EDIT: DONE

- Added new PythonQt::addWrapperFactory(PythonQtForeignWrapperFactory*) 
which allows to implement the VTK integration
  (or any other wrapper integration) externally (so you can do it in CTK)
See https://github.com/commontk/CTK/issues/157
EDIT: DONE

- PyMapping_Items -> PyObject_CallMethod fix not taken (PythonQtConversion.cpp), 
since it is not a good idea to expand PyMapping_Items just to get rid of the const char* 
warning (PyMapping_Items might change anytime in the future)

- renamed dPython.h to PythonQtPythonInclude and made it optional by adding a define check:  
  PYTHONQT_USE_RELEASE_PYTHON_FALLBACK and added that define to the CMake file list. 
See https://github.com/commontk/PythonQt/issues/4

- Changed polymorphic handler signature to const char** so that no const_cast<char*>
 is needed anymore

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions