Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus/authority] Add fetch rate limiting #136

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

patrick-ogrady
Copy link
Contributor

No description provided.

@patrick-ogrady patrick-ogrady marked this pull request as ready for review October 18, 2024 18:04
@patrick-ogrady patrick-ogrady merged commit 41e3913 into commonware-consensus Oct 18, 2024
3 checks passed
@patrick-ogrady patrick-ogrady deleted the add-fetch-rate-limiting branch October 18, 2024 18:23
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.11%. Comparing base (c86abd5) to head (83e9fe6).
Report is 1 commits behind head on commonware-consensus.

Files with missing lines Patch % Lines
consensus/src/authority/actors/resolver/actor.rs 75.00% 12 Missing ⚠️
consensus/src/mocks/application.rs 66.66% 1 Missing ⚠️
@@                   Coverage Diff                    @@
##           commonware-consensus     #136      +/-   ##
========================================================
- Coverage                 92.17%   92.11%   -0.07%     
========================================================
  Files                        60       60              
  Lines                     12952    13008      +56     
========================================================
+ Hits                      11939    11982      +43     
- Misses                     1013     1026      +13     
Files with missing lines Coverage Δ
consensus/src/authority/engine.rs 91.35% <100.00%> (+0.10%) ⬆️
consensus/src/authority/mod.rs 96.35% <100.00%> (+0.02%) ⬆️
consensus/src/mocks/application.rs 97.29% <66.66%> (+0.12%) ⬆️
consensus/src/authority/actors/resolver/actor.rs 84.99% <75.00%> (-0.77%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86abd5...83e9fe6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant