-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS-4927 - Intermediary select pages #182
Open
wjrm500
wants to merge
8
commits into
main
Choose a base branch
from
FS-4927_intermediary-select-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+321
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 3, 2025 18:09
03779f7
to
99d0277
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 12:20
bf7a680
to
d0e8bf3
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 12:31
d0e8bf3
to
ba2ed19
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 12:43
ba2ed19
to
187873a
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 13:06
a1ff6fe
to
3c72e60
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 13:08
3c72e60
to
fc9b8bb
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 13:09
fc9b8bb
to
f2c2911
Compare
…cation' before 'Build application'
…ion' intermediary pages
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 13:18
f2c2911
to
1cdc4aa
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 13:38
7293e23
to
b8e0c3e
Compare
wjrm500
force-pushed
the
FS-4927_intermediary-select-pages
branch
from
January 6, 2025 13:42
b8e0c3e
to
a682496
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://mhclgdigital.atlassian.net/browse/FS-4927
Understanding the changes
When accessing "Create a Round" or "Build Application" from the Home page, we need additional context in order to understand:
Currently we get that context by:
We are now changing the way we get that contextual information from the user. We are doing this with intermediary "Select" pages:
This change allows us to remove the problematic "View fund" page, and to neatly implement the "Save and continue" flow that will link "Create a Fund" to "Create a Round", and "Create a Round" to "Build Application".
How to test the changes
Pre-requisites
Test suite 1 - Create a Round
Expected behaviours...
Test suite 2 - Build Application
Expected behaviours...
UI screenshots