Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-4927 - Intermediary select pages #182

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wjrm500
Copy link
Contributor

@wjrm500 wjrm500 commented Jan 3, 2025

Ticket

https://mhclgdigital.atlassian.net/browse/FS-4927

Understanding the changes

When accessing "Create a Round" or "Build Application" from the Home page, we need additional context in order to understand:

  • For "Create a Round" - which fund we are creating a round for
  • For "Build Application" - which application's tasklist we are modifying

Currently we get that context by:

  • For "Create a Round" - by asking the user to select a fund from a drop-down at the top of the page
  • For "Build Application" - by asking the user to select a fund and a round for that fund on the "View fund" page accessed via "Manage Application Configuration"

We are now changing the way we get that contextual information from the user. We are doing this with intermediary "Select" pages:

  • For "Create a Round" - we show the user a page asking them to select a grant (renamed from fund). We no longer need to ask for grant on the "Create a Round" page itself
  • For "Build Application" - we show the user consecutive pages asking them to select a grant, and then a round (or application - we are renaming round to application) within that grant

This change allows us to remove the problematic "View fund" page, and to neatly implement the "Save and continue" flow that will link "Create a Fund" to "Create a Round", and "Create a Round" to "Build Application".

How to test the changes

Pre-requisites

Test suite 1 - Create a Round

Expected behaviours...

  • Action: Click "Create a Round" from Home page
  • Assert: The "Select a grant" page should appear, asking you to select a grant. It should look like this design

  • Action: Click "Back" from the "Select a grant" page
  • Expected behaviour: You should be taken back to the Home page

  • Action: Click "Add a new grant" from the "Select a grant" page
  • Expected behaviour: You should be taken to the "Create a Fund" page

  • Action: Click "Continue" from the "Select a grant" page without selecting a grant
  • Expected behaviour: You should be prevented from continuing, with a notification "Please select an item in the list"

  • Action: Click "Continue" from the "Select a grant" page with a grant selected
  • Expected behaviour: You should be taken to the "Create a Round" page, and the hyperlinked title of the selected grant should appear beneath the title, along with the hyperlink "Change grant"

  • Action: Click the hyperlinked grant title from the "Create a Round" page
  • Expected behaviour: You should be taken to the "Update a Fund" page, with grant data pre-populated

  • Action: Click the hyperlink "Change grant" from the "Create a Round" page
  • Expected behaviour: You should be taken back to the "Select a grant" page

  • Action: Click "Cancel" from the "Select a grant" page
  • Expected behaviour: You should be taken back to the Home page

Test suite 2 - Build Application

Expected behaviours...

  • Action: Click "Build Application" from Home page
  • Assert: The "Select a grant" page should appear, asking you to select a grant from which to build an application

  • Action: Click "Continue" from the "Select a grant" page with a grant selected
  • Expected behaviour: The "Select an application" page should appear, asking you to select an application. It should look like this design

  • Action: Click "Back" from the "Select an application" page
  • Expected behaviour: You should be taken back to the "Select a grant" page

  • Action: Click "Continue" from the "Select an application" page without selecting an application
  • Expected behaviour: You should be prevented from continuing, with a notification "Please select an item in the list"

  • Action: Click "Continue" from the "Select an application" page with an application selected
  • Expected behaviour: You should be taken to the "Build Application" page, with the grant short name, round title and round short name displayed underneath the title

  • Action: Click "Cancel" from any of the selection pages
  • Expected behaviour: You should be taken back to the Home page

UI screenshots

image

image

image

@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from bf7a680 to d0e8bf3 Compare January 6, 2025 12:20
@wjrm500 wjrm500 marked this pull request as ready for review January 6, 2025 12:20
@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from d0e8bf3 to ba2ed19 Compare January 6, 2025 12:31
@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from ba2ed19 to 187873a Compare January 6, 2025 12:43
@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from a1ff6fe to 3c72e60 Compare January 6, 2025 13:06
@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from 3c72e60 to fc9b8bb Compare January 6, 2025 13:08
@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from fc9b8bb to f2c2911 Compare January 6, 2025 13:09
@wjrm500 wjrm500 force-pushed the FS-4927_intermediary-select-pages branch from b8e0c3e to a682496 Compare January 6, 2025 13:42
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant