Skip to content

Commit

Permalink
comment out python changes
Browse files Browse the repository at this point in the history
  • Loading branch information
gidsg committed Dec 20, 2024
1 parent a5cc862 commit 97096dc
Showing 1 changed file with 51 additions and 63 deletions.
114 changes: 51 additions & 63 deletions .github/workflows/just-run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,6 @@ on:
default: true
type: boolean
description: Run e2e tests (assessment)
run_python_e2e_tests:
required: false
default: true
type: boolean
description: Whether to run the python e2e tests
python_e2e_copilot_environment:
description: "Copilot environment to run tests on"
type: choice
options:
- dev
- test
default: dev

jobs:
run_shared_tests_dev:
Expand Down Expand Up @@ -88,57 +76,57 @@ jobs:
FS_BASIC_AUTH_PASSWORD: ${{ secrets.FS_BASIC_AUTH_PASSWORD }}
AWS_ACCOUNT: ${{ secrets.AWS_ACCOUNT }}

run_python_tests:
if: ${{ always() && inputs.run_python_e2e_tests == true }}
name: python e2e tests
permissions:
contents: read # This is required for actions/checkout
id-token: write # This is required for requesting the JWT
runs-on: ubuntu-latest
environment: ${{ inputs.python_e2e_copilot_environment }}
steps:
- name: Get current date
shell: bash
id: currentdatetime
run: echo "datetime=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
# run_python_tests:
# if: ${{ always() && inputs.run_python_e2e_tests == true }}
# name: python e2e tests
# permissions:
# contents: read # This is required for actions/checkout
# id-token: write # This is required for requesting the JWT
# runs-on: ubuntu-latest
# environment: ${{ inputs.python_e2e_copilot_environment }}
# steps:
# - name: Get current date
# shell: bash
# id: currentdatetime
# run: echo "datetime=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT

- name: Setup AWS credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT }}:role/GithubCopilotDeploy
role-session-name: "python_e2e_${{ inputs.python_e2e_copilot_environment }}_copilot_${{ steps.currentdatetime.outputs.datetime }}"
aws-region: eu-west-2
# - name: Setup AWS credentials
# uses: aws-actions/configure-aws-credentials@v4
# with:
# role-to-assume: arn:aws:iam::${{ secrets.AWS_ACCOUNT }}:role/GithubCopilotDeploy
# role-session-name: "python_e2e_${{ inputs.python_e2e_copilot_environment }}_copilot_${{ steps.currentdatetime.outputs.datetime }}"
# aws-region: eu-west-2

- name: Generate a token
id: generate_token
uses: actions/create-github-app-token@v1.6.4
with:
app-id: ${{ secrets.FSD_GH_APP_ID }}
private-key: ${{ secrets.FSD_GH_APP_KEY }}
owner: ${{ github.repository_owner }}
repositories: "funding-service-design-e2e-checks"
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- name: Checkout E2E tests
uses: actions/checkout@v4.1.1
with:
repository: communitiesuk/funding-service-design-e2e-checks
token: ${{ steps.generate_token.outputs.token }}
- name: Install the latest version of uv
uses: astral-sh/setup-uv@e779db74266a80753577425b0f4ee823649f251d # v3
with:
enable-cache: true
- name: Install playwright browsers
# working-directory: funding-service-design-e2e-checks
run: uv run --frozen playwright install --with-deps chromium
# - name: Generate a token
# id: generate_token
# uses: actions/create-github-app-token@v1.6.4
# with:
# app-id: ${{ secrets.FSD_GH_APP_ID }}
# private-key: ${{ secrets.FSD_GH_APP_KEY }}
# owner: ${{ github.repository_owner }}
# repositories: "funding-service-design-e2e-checks"
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
# - name: Checkout E2E tests
# uses: actions/checkout@v4.1.1
# with:
# repository: communitiesuk/funding-service-design-e2e-checks
# token: ${{ steps.generate_token.outputs.token }}
# - name: Install the latest version of uv
# uses: astral-sh/setup-uv@e779db74266a80753577425b0f4ee823649f251d # v3
# with:
# enable-cache: true
# - name: Install playwright browsers
# # working-directory: funding-service-design-e2e-checks
# run: uv run --frozen playwright install --with-deps chromium

- name: Run tests
# working-directory: funding-service-design-e2e-checks
run: uv run --frozen pytest --e2e-env ${{ inputs.python_e2e_copilot_environment }} --tracing=retain-on-failure --browser chromium
env:
E2E_DEVTEST_BASIC_AUTH_USERNAME: ${{ secrets.E2E_DEVTEST_BASIC_AUTH_USERNAME }}
E2E_DEVTEST_BASIC_AUTH_PASSWORD: ${{ secrets.E2E_DEVTEST_BASIC_AUTH_USERNAME }}
- uses: actions/upload-artifact@v4
if: ${{ !cancelled() }}
with:
name: playwright-traces
path: test-results/
# - name: Run tests
# # working-directory: funding-service-design-e2e-checks
# run: uv run --frozen pytest --e2e-env ${{ inputs.python_e2e_copilot_environment }} --tracing=retain-on-failure --browser chromium
# env:
# E2E_DEVTEST_BASIC_AUTH_USERNAME: ${{ secrets.E2E_DEVTEST_BASIC_AUTH_USERNAME }}
# E2E_DEVTEST_BASIC_AUTH_PASSWORD: ${{ secrets.E2E_DEVTEST_BASIC_AUTH_USERNAME }}
# - uses: actions/upload-artifact@v4
# if: ${{ !cancelled() }}
# with:
# name: playwright-traces
# path: test-results/

0 comments on commit 97096dc

Please sign in to comment.