Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use niquests #7

Merged
merged 45 commits into from
Nov 25, 2024
Merged

Use niquests #7

merged 45 commits into from
Nov 25, 2024

Conversation

vrslev
Copy link
Contributor

@vrslev vrslev commented Nov 22, 2024

No description provided.

vrslev
vrslev commented Nov 22, 2024
View reviewed changes
Copy link
Contributor Author

@vrslev vrslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to test with niquests. They don't have utilities for that, which is unfortunate. Also there're edge cases with exceptions, I can't predict when attributes will be None.

vrslev
vrslev commented Nov 22, 2024
View reviewed changes
Copy link
Contributor Author

@vrslev vrslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be possible to wrap niquests with an abstraction, but still I'm not sure it would work as expected (like httpx)

@vrslev
Copy link
Contributor Author

vrslev commented Nov 22, 2024

I'm going to close this for now. If anyone wants to, they can continue on with this. Maybe I revisit it later myself.

@vrslev
Copy link
Contributor Author

vrslev commented Nov 22, 2024

@xfenix @insani7y FYI

@vrslev vrslev closed this Nov 22, 2024
@vrslev vrslev reopened this Nov 24, 2024
@vrslev vrslev marked this pull request as draft November 24, 2024 09:16
@vrslev vrslev closed this Nov 24, 2024
@vrslev vrslev reopened this Nov 25, 2024
@vrslev vrslev marked this pull request as ready for review November 25, 2024 18:56
@vrslev vrslev merged commit bfaec30 into main Nov 25, 2024
4 checks passed
@vrslev vrslev deleted the niquests branch November 25, 2024 18:58
vrslev added a commit that referenced this pull request Dec 5, 2024
@vrslev
Revert "Use niquests (#7)"
24165ce 
This reverts commit bfaec30.
vrslev added a commit that referenced this pull request Dec 5, 2024
@vrslev
Move back to HTTPX (#13)
ec25bed 
* Revert "Use niquests (#7)"

This reverts commit bfaec30.

* Leave good stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vrslev