Skip to content

Conversation

lesnik512
Copy link
Member

@lesnik512 lesnik512 commented Dec 6, 2024

What's changed:

  • unlocked package versions. Updated: lower constraints added
  • .gitignore cleared from unused sections
  • added poetry.lock to .gitignorу. Discussed here with @vrslev allow overriding in injections modern-python/that-depends#80 (comment)
  • added justfile
  • moved typing_extensions to dev section
  • removed typing.Self from self annotation (it's not needed)
  • full mypy strict with type ignores, where needed. This way we ignore only when required without missing any mypy warning
  • fastapi.testclient.TestClient used for fastapi tests

@lesnik512 lesnik512 requested review from insani7y and vrslev December 6, 2024 08:57
@lesnik512 lesnik512 self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 98.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
microbootstrap/bootstrappers/base.py 96.36% <100.00%> (-0.07%) ⬇️
microbootstrap/bootstrappers/fastapi.py 97.10% <100.00%> (ø)
microbootstrap/config/fastapi.py 100.00% <100.00%> (ø)
microbootstrap/instruments/base.py 94.11% <100.00%> (ø)
microbootstrap/instruments/cors_instrument.py 100.00% <100.00%> (ø)
microbootstrap/instruments/instrument_box.py 100.00% <ø> (ø)
microbootstrap/instruments/logging_instrument.py 98.68% <ø> (ø)
...obootstrap/instruments/opentelemetry_instrument.py 100.00% <100.00%> (ø)
microbootstrap/instruments/sentry_instrument.py 100.00% <100.00%> (ø)
microbootstrap/instruments_setupper.py 100.00% <ø> (ø)
... and 1 more

@lesnik512
Copy link
Member Author

lesnik512 commented Dec 6, 2024

I'll fix lint-and-typecheck when discussion will be resolved #49

@vrslev
Copy link
Contributor

vrslev commented Dec 6, 2024

@insani7y take a look at discussion #49

@vrslev
Copy link
Contributor

vrslev commented Dec 6, 2024

@lesnik512 do you have push & release rights?

@lesnik512
Copy link
Member Author

Yes

@lesnik512 lesnik512 merged commit 67632fd into main Dec 7, 2024
15 checks passed
@lesnik512 lesnik512 deleted the feature/refactor branch December 7, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants