Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RAM and Disk units #1261

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Add RAM and Disk units #1261

merged 3 commits into from
Jan 5, 2025

Conversation

oOStroudyOo
Copy link
Contributor

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.


✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

Added the units of MB to RAM and GB to Disk size when using advanced settings.


Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • [✅] Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • [✅] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • [✅] Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • [✅] Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

image

@oOStroudyOo oOStroudyOo requested a review from a team as a code owner January 5, 2025 15:16
@github-actions github-actions bot added the high risk A change that can affect many scripts label Jan 5, 2025
@MickLesk
Copy link
Member

MickLesk commented Jan 5, 2025

MiB ? Never ever used MIB

@oOStroudyOo
Copy link
Contributor Author

oOStroudyOo commented Jan 5, 2025

MiB ? Never ever used MIB

Proxmox shows it as MiB, and the prompt on line 489 also asks for MiB.
image

1024 MiB would be 1 GiB, but 1024 MB would be 0.95 GiB

Likewise for Storage actually. The node and datacentre show GiB, and when you try to resize disk, but when you click on your storage it shows GB.

The default disk size that we set (2), is actually 2.14 GB
image

@MickLesk MickLesk merged commit 81ffa34 into community-scripts:main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high risk A change that can affect many scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants