Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved minor issues in Add Company. #43

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Solved minor issues in Add Company. #43

merged 5 commits into from
Jun 23, 2020

Conversation

amolsontakke3576
Copy link
Contributor

Screenshot from 2020-06-23 14-43-51

@amolsontakke3576
[#1285 #1286 #1287] Solved company name validation issue
6c125a3 
Added max length validation
Added regex validation as per organization service

Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
Solved lint issue
fbd47b2 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1287] Solved error display issue
2814f3b 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
[#1285] Solved minlength issue of company name
5d05882 
Changed url regex to allow only number in path

Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576
Solved conflict
7d797cb 
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
@amolsontakke3576 amolsontakke3576 added the bug Something isn't working label Jun 23, 2020
@amolsontakke3576 amolsontakke3576 self-assigned this Jun 23, 2020
@amolsontakke3576
Copy link
Contributor Author

@nirupamav Can you please confirm error message in attachment above.

dealako
dealako approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@dealako dealako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dealako dealako merged commit 8cbcc13 into communitybridge:master Jun 23, 2020
@amolsontakke3576 amolsontakke3576 deleted the bug/1285_add_company_validation branch November 9, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dealako dealako dealako approved these changes

@nirupamav nirupamav Awaiting requested review from nirupamav

Assignees

@amolsontakke3576 amolsontakke3576

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amolsontakke3576 @dealako