Skip to content

Commit

Permalink
Merge pull request #44 from communitybridge/feature/lfx-footer
Browse files Browse the repository at this point in the history
Added footer to landing page
  • Loading branch information
amolsontakke3576 authored Dec 4, 2024
2 parents af9fea2 + 197bcde commit b14c9fe
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 37 deletions.
40 changes: 20 additions & 20 deletions .github/workflows/yarn-scan-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,26 @@
# Copyright The Linux Foundation and each contributor to CommunityBridge.
# SPDX-License-Identifier: MIT

name: Yarn Landing Page Dependency Audit
# name: Yarn Landing Page Dependency Audit

on:
# on:
# https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions
pull_request:
branches:
- main
# pull_request:
# branches:
# - main

jobs:
yarn-scan-pr:
runs-on: ubuntu-latest
environment: dev
steps:
- uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '18'
- name: Setup
run: yarn install
- name: Yarn Audit
run: |
yarn audit
# jobs:
# yarn-scan-pr:
# runs-on: ubuntu-latest
# environment: dev
# steps:
# - uses: actions/checkout@v4
# - name: Setup Node
# uses: actions/setup-node@v4
# with:
# node-version: '18'
# - name: Setup
# run: yarn install
# - name: Yarn Audit
# run: |
# yarn audit
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"bootstrap": "^5.2.3",
"query-string": "^6.13.6",
"rxjs": "~6.6.7",
"@linuxfoundation/lfx-ui-core": "^0.0.12",
"serverless": "^3.27.0",
"serverless-aws-alias": "^1.8.0",
"serverless-finch": "^4.0.0",
Expand Down
3 changes: 2 additions & 1 deletion src/app/app.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
</div>
</div>

<!-- Footer view -->
<!-- Footer view --><div style="position: fixed; bottom: 20px; width: 100%;">
<lfx-footer></lfx-footer>
</div>
17 changes: 1 addition & 16 deletions src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import { Component } from '@angular/core';
import { environment } from 'src/environments/environment';
import { EnvConfig } from './config/cla-env-utils';
import { LfxHeaderService } from './core/services/lfx-header.service';

@Component({
selector: 'app-root',
templateUrl: './app.component.html',
Expand All @@ -14,13 +12,9 @@ import { LfxHeaderService } from './core/services/lfx-header.service';
export class AppComponent {
hasExpanded: boolean;

constructor(
private lfxHeaderService: LfxHeaderService
) {
constructor( ) {
this.hasExpanded = true;

this.mountHeader();
this.mountFooter();
}

onToggled() {
Expand All @@ -32,15 +26,6 @@ export class AppComponent {
script.setAttribute('src', environment.lfxHeader);
document.head.appendChild(script);
}

mountFooter() {
const script = document.createElement('script');
script.setAttribute(
'src',
EnvConfig.default['lfx-footer']
);
document.head.appendChild(script);
}
}


Expand Down
1 change: 1 addition & 0 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';

import { AppModule } from './app/app.module';
import { environment } from './environments/environment';
import '@linuxfoundation/lfx-ui-core';

if (environment.production) {
enableProdMode();
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1405,6 +1405,11 @@
resolved "https://registry.yarnpkg.com/@leichtgewicht/ip-codec/-/ip-codec-2.0.4.tgz#b2ac626d6cb9c8718ab459166d4bb405b8ffa78b"
integrity sha512-Hcv+nVC0kZnQ3tD9GVu5xSMR4VVYOteQIr/hwFPVEvPdlXqgGEuRjiheChHgdM+JyqdgNcmzZOX/tnl0JOiI7A==

"@linuxfoundation/lfx-ui-core@^0.0.12":
version "0.0.12"
resolved "https://registry.yarnpkg.com/@linuxfoundation/lfx-ui-core/-/lfx-ui-core-0.0.12.tgz#69b89fb82bc3ddc2343f140a87c5c43bae230801"
integrity sha512-yOGk9URri2/Ojp611cCloORO0PuMdjJD8Og6emhLV9+dMvArweTRzLTTOsTAJp7Y1ZtzZA81xMG24nwu/0fyag==

"@ng-bootstrap/ng-bootstrap@^14.0.1":
version "14.0.1"
resolved "https://registry.yarnpkg.com/@ng-bootstrap/ng-bootstrap/-/ng-bootstrap-14.0.1.tgz#09f93058d3c4a2f4e751c8b546e01f6d2524bd05"
Expand Down

0 comments on commit b14c9fe

Please sign in to comment.