EasyCLA Bug Report: Confusing project information in new administrator notice

[jberkus]

Summary

When new administrators are notified via email of their status, the project named in the notification email is incorrect.

Background

1. Added a new administrator for Red Hat, project CNCF.
2. The new admin received an email that said this:

"You have been added as a CLA Manager for the organization Red Hat, Inc. and the project OpenTelemetry. This means that you can now maintain the list of employees allowed to contribute to the project OpenTelemetry on behalf of your company, as well as view and manage the list of your company’s CLA Managers for the CLA Group Cloud Native Computing Foundation (CNCF)."

This is incorrect; the added administrator has permissions over signers for the entire CNCF (which they should). Nor are there any specific permissions associated with the OpenTelemetry project.

Expected behavior

The email should have said:

"You have been added as a CLA Manager for the organization Red Hat, Inc. for the CLA Group Cloud Native Computing Foundation (CNCF)."

A clear and concise description of what you expected to happen.

Environment

Please complete the following information:

• Environment:
  • PROD
  • [ ]
• Browser:
  • Not applicable

[jberkus]

This appears to be a more general bug where any email about our CNCF-level permissions gets attributed to OpenTelemetry instead. We just got another email:

This is a notification email from EasyCLA regarding the project OpenTelemetry.

q () has been removed as a CLA Manager from Red Hat, Inc. for the project OpenTelemetry.

[WillsonHG]

This has been added to our tracker and we will be investigating the issue.

[mlehotskylf]

@jberkus we believe this issue has been resolved. Can you please confirm this issue is no longer occurring?
Thank you!

[mlehotskylf]

@jberkus please let us know, if no response in one week this ticket will be closed automatically. Thank you for understanding.

[jberkus]

I cannot verify it at this time, given that it requires adding or removing an administrator, something that we can only do when staffing is actually changing.

[thakurveerendras]

@mlehotskylf , @nickmango , The Issue is still reproducible as reported on the dev site. Kindly update the email text as mentioned in expected section above

[jberkus]

This is still broken.

I just had to remove an administrator today, and got the attached:

[nickmango]

Noted @jberkus . Will have this updated

[nickmango]

@thakurveerendras kindly verify this
context is the cla_group_id has to be signed at the foundation level..(at least there has to be association between foundation and cla_group, which should be the case for the Sun project)

[thakurveerendras]

Tested on dev site & found that proper (parent) project name appears while added/deleted PM from enrolled child project

Refer to the screenshot

[nickmango]

@jberkus this was resolved and tested internally.. Whenever you get an opportunity you can verify on your end. Thanks

[jberkus]

Will do. I can only test it by adding/removing an administrator, which is not something I can casually do without informing management.

[jberkus]

This has still not been fixed. I added a new admin for CNCF, and this is the notice I got:

Hello ,

This is a notification email from EasyCLA regarding the project OpenTelemetry associated with the CLA Group Cloud Native Computing Foundation (CNCF).

The following user has been added as a CLA Manager from Red Hat, Inc. for the project OpenTelemetry. This means that they can now maintain the list of employees allowed to contribute to OpenTelemetry on behalf of your company, as well as view and manage the list of company’s CLA Managers for OpenTelemetry.

[mlehotskylf]

Thank you @jberkus for letting us know and sorry for the delay. We will take a look at this shortly.

[nickmango]

@thakurveerendras kindly review.

[thakurveerendras]

Hi @nickmango
Cla-group name is wrong for the child project in the email, it is showing the parent project cla-group name

• Parent project: SUN,

CLA-Group name: Sun foundation cla group.

• Child project: Earth,

CLA-Group name: earth child cla group

I have added cla-manager to child project & mail received for foundation project

[mlehotskylf]

@nickmango is working on PR. @thakurveerendras please re-verify once merged.

[nickmango]

@thakurveerendras Kindly reverify - focus on child projects has been deprecated and CLA Group Naming will be used in the email body

[thakurveerendras]

Hello @nickmango , @mlehotskylf
It is still failing for the notice received at the existing cla-manager on the child project

Project: CLA-Manger	Email Subject	Status	Screenshot
Parent project : SUN - Existing cla-manger	EasyCLA: CLA Manager Added Notice for Sun foundation cla group	Passed
Parent project: SUN -Newly added cla-manager	EasyCLA: CLA Manager Added Notice for Sun foundation cla group	Passed
Child project: Earth - Existing cla-manger	EasyCLA: CLA Manager Added Notice for earth child cla group	Failed: SUN project cla-group details appears
Child project: Earth -Newly added cla-manager	EasyCLA: Added as CLA Manager for Project :earth child cla group	Passed

[nickmango]

@thakurveerendras kindly review

[thakurveerendras]

Hello @nickmango
Tested failed case & found that it is working fine, So updating this ticket status

Refer to the screenshot