Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore #4484

Merged
merged 13 commits into from
Dec 4, 2024
Merged

Update gitignore #4484

merged 13 commits into from
Dec 4, 2024

Conversation

lukaszgryglicki
Copy link
Contributor

@mlehotskylf - just wanted to make sure that some files I use locally are not committed to the repo.

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
mlehotskylf
mlehotskylf previously approved these changes Nov 20, 2024
@lukaszgryglicki
Copy link
Contributor Author

Still I can't merge @mlehotskylf due to CI failures not related to this PR - can u merge?

@lukaszgryglicki
Copy link
Contributor Author

lint-test-build never finished, is this a bug @mlehotskylf - it is listed as "required" and didn't finish since yesterday...

@lukaszgryglicki
Copy link
Contributor Author

@mlehotskylf this is still not resolved.

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
@lukaszgryglicki
Copy link
Contributor Author

lint-test-build still blocks this @mlehotskylf

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
mlehotskylf
mlehotskylf previously approved these changes Dec 4, 2024
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>
Copy link
Collaborator

@nickmango nickmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukaszgryglicki lukaszgryglicki merged commit 4e6f043 into dev Dec 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants