Migrate infrastructure code to Terraform 1.3

[marcransome]

These changes upgrade the codebase to work with Terraform version 1.3 and include the following modifications and improvements:

• Update Terraform version constraint
• Update terraform-modules/aws/instance_profile module version
• Update AWS provider version constraint
• Replace deprecated AWS provider data source aws_subnet_ids with aws_subnets
• Reorder input variables, update descriptions for consistency across stacks, and add additional type constraints
• Replace attribute-only splat expressions (.*) with the new syntax ([*])
• Simplify log group handling and internal data structure conversion
• Replace duplicate ternary expressions with single-expression local variable representing resource count
• Remove unnecessary dynamic blocks
• Remove empty source files

Related: https://github.com/companieshouse/ci-pipelines/pull/2659.