Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated pip option #1136

Merged
merged 3 commits into from
Apr 19, 2023
Merged

removed deprecated pip option #1136

merged 3 commits into from
Apr 19, 2023

Conversation

chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Apr 18, 2023

Same change as in compas-dev/compas-actions.build#2.

Unrelated, but to fix the ironpython build fixed a broken unittest as well.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

assert area_polygon(polygon) >= 0
# the same polygon with vertices list shifted by 3 positions :
polygon_ = Polygon(polygon[3:] + polygon[:3])
polygon_ = polygon[3:] + polygon[:3]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯

@chenkasirer chenkasirer merged commit 4c7b20c into main Apr 19, 2023
@chenkasirer chenkasirer deleted the install_option branch April 19, 2023 07:48
@gonzalocasas gonzalocasas restored the install_option branch April 23, 2023 10:12
@gonzalocasas gonzalocasas mentioned this pull request Apr 23, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants