Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicates2 new methods addition #1153

Open
wants to merge 181 commits into
base: main
Choose a base branch
from

Conversation

baehrjo
Copy link
Contributor

@baehrjo baehrjo commented Jun 8, 2023

I added new predicates in predicates_2 for both point/polygon(XY) and polygon/polygon(XY): polygon_to_polygon_relationship_xy, point_to_polygon_relationship_xy, is_intersection_polygon_polygon_xy
Full documentation provided in the methods comments. There are on purpose overlaps in what the methods are doing, for instance 'polygon_to_polygon_relationship_xy' first checks for intersection, then for containment, and if not deducts that the polygon is outside instead of calling separate methods. Separate methods ('is_polygon_in_polygon_xy', 'is_intersection_polygon_polygon_xy', ...) are still useful when looking for a True/False answer only.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • [x ] New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • [x ] I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • [x ] I have added tests that prove my fix is effective or that my feature works.
  • [x ] I have added necessary documentation (if appropriate)

@tomvanmele
Copy link
Member

@baehrjo #1130 is merged. please resolve the conflicts by merging main into your PR branch so we can get this one done as well...

@tomvanmele
Copy link
Member

@baehrjo i think you still need to merge main back into your branch, or rebase it onto main...

@baehrjo
Copy link
Contributor Author

baehrjo commented Nov 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants