Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum line length in SETCSLL #4

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Conversation

mortenpi
Copy link
Member

I implemented @tspejo's suggested fix. Per, I was hoping that you could take a look at this to make sure I understood your email correctly.

@mrgodef @kaiwang1128 I was hoping that either of you could checkout the PR and test it. For that, assuming you have not cloned the repo already, you need to do:

git clone https://github.com/compas/grasp2018.git
cd grasp2018/
git checkout mp/fix-csl-loading

After that you should, just in case, run git log to make sure that you have the correct branch (last commit should be mine with the title "Increase maximum line length in SETCSLL"), and git status to make sure that there are no other local changes. And then compile and test that the issue you were seeing is gone.

This allows for CSLs that have up to 20 open shells at least.

Co-authored-by: Per Jönsson <per.jonsson@mah.se>
@mortenpi mortenpi requested a review from cffischer November 30, 2018 22:56
@cffischer
Copy link
Member

The GRASP programs are 1990's style in that memory allocation is expected to be dealt with by parameters. The parameter NNNW specifies the maximum number of orbitals. Users may wish to have all shells active so technically the program should allow for 127 open shells. Per has just increased it to about 20, so expect this error to occur again.

@mrgodef
Copy link
Member

mrgodef commented Dec 1, 2018

I think that Charlotte is right. As far as I understood from an email of Kai that I got this afternoon, the error of « missing parity » occurs in one of his calculations.

@mortenpi mortenpi merged commit 2f51bbd into master Dec 2, 2018
@mortenpi mortenpi deleted the mp/fix-csl-loading branch December 2, 2018 23:00
@mortenpi mortenpi restored the mp/fix-csl-loading branch December 2, 2018 23:01
@mrgodef
Copy link
Member

mrgodef commented Dec 3, 2018

We are confirming that Kai's bug on the missing parity disappeared after recompiling rangular, rmcdhf and rci. Great and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants