Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate jQuery dependency in PolisNet #364

Open
colinmegill opened this issue Jun 25, 2020 · 7 comments
Open

Reevaluate jQuery dependency in PolisNet #364

colinmegill opened this issue Jun 25, 2020 · 7 comments

Comments

@colinmegill
Copy link
Member

colinmegill commented Jun 25, 2020

@colinmegill
Copy link
Member Author

Fetch polyfills may not align with our browser support matrix.

@patcon
Copy link
Contributor

patcon commented Jun 25, 2020

Also something from the cy.server() docs to keep in mind if using fetch:

🚨 Please be aware that Cypress only currently supports intercepting XMLHttpRequests. Requests using the Fetch API and other types of network requests like page loads and <script> tags will not be intercepted or visible in the Command Log. You can automatically polyfill window.fetch to spy on and stub requests by enabling an experimental feature experimentalFetchPolyfill. See cypress-io/cypress#95 for more details and temporary workarounds.

@patcon
Copy link
Contributor

patcon commented Jul 30, 2020

Related? #453

@patcon
Copy link
Contributor

patcon commented Jul 30, 2020

Fetch polyfills may not align with our browser support matrix.

Current v3.2 fetch polyfill works on IE10+, and that holds true back to at least v1.0.0

This seems to align with our browser support goals for client-admin and client-report, but not client-participation #166

@patcon
Copy link
Contributor

patcon commented Jul 30, 2020

Re: cypress tests. cypress-io/cypress#95 (comment)

@patcon
Copy link
Contributor

patcon commented Jul 30, 2020

@colinmegill what's the story with Client-participation having another set of "net" utilities based around backbone? Could it be whittled down to just one? (Only seeing net/bbfetch actually being used in codebase rn)

https://github.com/pol-is/polis/tree/dev/client-participation/js/net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants