-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 and IE9 support #2
Comments
Apart from needing a polyfill for |
https://github.com/es-shims/es5-shim and https://github.com/jakearchibald/es6-promise should do the trick, JSON is natively supported by these browsers |
Worth noting that this is the case only in standards mode. |
Ah, excellent! It sounds like ES5 get/set isn't used, and so this should work well with IE8 and the shims @brendanmoore linked to. It would be great if the browser support table at the bottom of the page could have a new row called "support with shims", to indicate that this project can be used with IE8 (and other old browsers), with a comment/link to the shims. |
On closer inspection this uses |
The browsers listed in the support matrix are guaranteed to work well with this polyfill because we support them at GitHub. IE9 can be made to work by adding the Promise polyfill listed at the top of the readme. |
"The browsers listed in the support matrix are guaranteed to work well with this polyfill because we support them at GitHub. IE9 can be made to work by adding the Promise polyfill listed at the top of the readme." This needs to be mentioned in the readme. There's "You'll also need a Promise polyfill for older browsers." but if someone views just the Browser Support section, that info should be there, including a mention of Internet Explorer and Edge. |
So has anyone actually tested this in IE8? I've got all the polyfills. |
@mnpenner The latest stable release 1.0 only supports IE10+. If you need to support IE9 you can use v0.11.x. If you need IE8 support you will need to fork the "0.11" branch and make your changes appropriately. |
Test signal reuse. Add AbortSignal polyfill.
What is the reason this does not work in IE8 and IE9? Could it be made so a shim or polyfill is all that is needed for older browsers to work?
The text was updated successfully, but these errors were encountered: