Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right-to-left (RTL) language support #513

Closed
1 task
patcon opened this issue Aug 10, 2020 · 15 comments
Closed
1 task

Add right-to-left (RTL) language support #513

patcon opened this issue Aug 10, 2020 · 15 comments

Comments

@patcon
Copy link
Contributor

patcon commented Aug 10, 2020

Re-ticketed from 💬 Gitter chat: https://gitter.im/pol-is/polisDeployment?at=5f30740e811d3571b3b83cad

cc: @sarilouis

To Do

  • expand on this issue
@patcon
Copy link
Contributor Author

patcon commented Aug 10, 2020

Related to lots of "localization" issues, but esp #435 (comment) and #320

@patcon
Copy link
Contributor Author

patcon commented Aug 10, 2020

Going to mark this as high-priority, as it came out in sync-up convo that this is critical to polis' use in Lebanon's crisis: https://hackmd.io/@patcon/B19Vz-kzw

cc: @patrickas

@avirankatzsofi
Copy link

avirankatzsofi commented Aug 11, 2020

We're based in Israel and are interested in using the platform, but not having proper RTL support is an issue for us.
Once RTL support is there, we'll gladly contribute a Hebrew translation

@patcon
Copy link
Contributor Author

patcon commented Aug 11, 2020

Thanks so much for chiming in, Aviran! In the meantime (before we have RTL support), would you be willing to provide translations in advance if I added he-IL as a locale option within our [work-in-progress] translation interface? https://polis-translations.herokuapp.com? Related: #320 #345

@patcon
Copy link
Contributor Author

patcon commented Aug 11, 2020

The main interface for participants is client-participation, which is a backbonejs app, not react.

Research

@avirankatzsofi
Copy link

avirankatzsofi commented Aug 12, 2020

Thanks so much for chiming in, Aviran! In the meantime (before we have RTL support), would you be willing to provide translations in advance if I added he-IL as a locale option within our [work-in-progress] translation interface? https://polis-translations.herokuapp.com? Related: #320 #345

No problem. I'm not familiar with Mojito, looks neat

@patcon
Copy link
Contributor Author

patcon commented Aug 12, 2020

Rockin. Ok, thanks @avirankatzsofi! I've added Hebrew as a locale, and it's ready for translation by anyone with a GitHub account 🙂

https://polis-translations.herokuapp.com/workbench?repoIds[]=1&repoIds[]=2&bcp47Tags[]=he-IL

@avirankatzsofi
Copy link

Rockin. Ok, thanks @avirankatzsofi! I've added Hebrew as a locale, and it's ready for translation by anyone with a GitHub account

https://polis-translations.herokuapp.com/workbench?repoIds[]=1&repoIds[]=2&bcp47Tags[]=he-IL

I tried to get back to it and continue with the translation, but the link is broken at the moment. Are you deprecating the use of mojito?

@patcon
Copy link
Contributor Author

patcon commented Jan 3, 2021

Yes, polis team requested it not have ppl directed to use it anymore, as it isn't possible to maintain with the limited capacity of the core team.

But it's def still possible to add new translations directly into the codebase :) you can copy the file for English into a new file beside the others, and submit a "pull request". That something you'd be comfortable doing? I'd be happy to walk you through it, or in a pinch, you could just make a google doc and I could make sure it's formatting and submitted into the codebase

cc @colinmegill

@avirankatzsofi
Copy link

Thanks @patcon! I'll find the time to add an he.js file.
If I were to translate only some of the strings, would the missing ones fallback to English?

@patcon
Copy link
Contributor Author

patcon commented Jan 4, 2021

Woo! Thanks for your willingness to give it a go!

would the missing ones fallback to English?

And yeah, exactly :) so something is better than nothing

@daniel-skywalker
Copy link
Contributor

Hello! Reviving this discussion - any news on the RTL issue?
After the Hebrew translation is completed, and towards making this tool popular in the regional climate conferences, visibility and UX really call for RTL display.
What can I do to help?

@metasoarous

@patcon
Copy link
Contributor Author

patcon commented May 4, 2021

Hey Daniel! Remind me, are you comfortable with JS programming? Or would you have anyone in your network who you could recruit to implement this?

I would imagine the first step would be for (1) someone research best-practices for this, (2) share some links to confirm their preferred approach, and then (3) making a quick proposal in this issue. Obviously, it's open source, so someone can just "write the code" with talking first, but after getting the 👍 , they could (4) dive into the work knowing that they were initiating work that's likely to be merged :)

EDIT: You're welcome to join these places:

  1. the official gitter dev chat: https://gitter.im/compdemocracy/polis-dev-chat
  2. or the unofficial polis user group's discord chat server: https://bit.ly/conversa-calls (we also run weekly orientation calls)

@daniel-skywalker
Copy link
Contributor

daniel-skywalker commented May 4, 2021 via email

@patcon
Copy link
Contributor Author

patcon commented May 4, 2021

I don't have any insight on that, so I'll leave someone else to respond with the inside scoop 🙏

I have further questions, but I don't think this issue is the appropriate place, so pls do jump into the discord chat linked above if you'd like to continue discussing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants