update configuration.md #1663
Merged
update configuration.md #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metasoarous
reviewed
Mar 30, 2023
metasoarous
reviewed
Mar 30, 2023
|
Line notes aside, there's two things I'd like to see:
I'll take a closer look at tomorrow hopefully. Thanks! |
xeeg
reviewed
Mar 30, 2023
ballPointPenguin
force-pushed
the
br/config-documentation
branch
from
cd40712
to
0312ee7
Compare
metasoarous
reviewed
Apr 5, 2023
| @@ -38,7 +38,7 @@ get very far. Still it can be useful for developing and debugging builds. | |||
|
|
|||
| The folowing environment variable can be set when building and running this application. If using the top-level `docker compose` configuration, it can be found in the `.env` file there. | |||
|
|
|||
| **SERVICE_URL**: (Optional) The URL of your API Server. Set this value if your API Server is not on the same domain as your client-report. | |||
| **`SERVICE_URL`**: (Optional) The URL of your API Server. Set this value if your API Server is not on the same domain as your client-report. | |||
There was a problem hiding this comment.
Should this actually be REPORT_SERVICE_URL? See #1666.
There was a problem hiding this comment.
Would still like clarification on this, but not blocking for now.
metasoarous
reviewed
Apr 6, 2023
|
|
||
| Values that have been renamed or replaced: | ||
|
|
||
| - **`DATABASE_FOR_READS_NAME`** has been replaced by **`READ_ONLY_DATABASE_URL`** |
There was a problem hiding this comment.
@ballPointPenguin This is somewhat problematic with usage on Heroku, since the main DATABASE_URL (and any read replica dbs) needs to be managed by the system. That's why we implemented DATABASE_FOR_READS_NAME as a pointer to the var that gets read from for the read only database.
There was a problem hiding this comment.
Lets fork this off as a separate issue
metasoarous
reviewed
Apr 9, 2023
metasoarous
reviewed
Apr 9, 2023
metasoarous
reviewed
Apr 9, 2023
STATIC_FILES_PARTICIPATION_PORT; typo and organization of configuration.md.
ballPointPenguin
force-pushed
the
br/config-documentation
branch
from
ba3832d
to
2018c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new docs/upgrading.md guide.
Detail every env var in docs/configuration.md.
Change the new STATIC_FILES_CLIENT_PORT to STATIC_FILES_PARTICIPATION_PORT