Fixed issues dependant libraries and rerun benchmarks #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @compenguy, I have some news - I have worked with @zommiommy to finish updating the integration of libraries like sux-rs and webgraph-rs. Now all tests pass, except for everything regarding trie-rs.
Now, I have made a pull request to the trie repo and all of its dependencies. Still, I have not received any reply from the authors there, and as
trie-rs
did not fare positively in our benchmarks I think we can remove it altogether as the RCL trumps trie in all relevant contexts.Tomorrow I will clean up the repo from all references of
trie-rs
and update the README accordingly. One big caveat is that in theCargo.toml
at this time there are still several GitHub crates, as some dependency versions have yet to be published on crates.io - we may have to wait a little bit for those to become stable.New benchmarks: