Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues dependant libraries and rerun benchmarks #14

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

LucaCappelletti94
Copy link
Contributor

Hi @compenguy, I have some news - I have worked with @zommiommy to finish updating the integration of libraries like sux-rs and webgraph-rs. Now all tests pass, except for everything regarding trie-rs.

Now, I have made a pull request to the trie repo and all of its dependencies. Still, I have not received any reply from the authors there, and as trie-rs did not fare positively in our benchmarks I think we can remove it altogether as the RCL trumps trie in all relevant contexts.

Tomorrow I will clean up the repo from all references of trie-rs and update the README accordingly. One big caveat is that in the Cargo.toml at this time there are still several GitHub crates, as some dependency versions have yet to be published on crates.io - we may have to wait a little bit for those to become stable.

New benchmarks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant