Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students, View Latest Doc, Padding Fix #133

Closed
10 tasks done
kasthurie opened this issue Jan 12, 2020 · 8 comments

Comments

@kasthurie
Copy link
Collaborator

kasthurie commented Jan 12, 2020

SubTask of #37

  • As a tutor, I would like to be able to delete the documents uploaded for one student. (Claudia)

  • As a tutor, I would like to be able to delete the documents uploaded for many students. (Claudia , Wait for Pierre's function for it).

  • Add reload function (Kasthurie).

  • As a tutor, i would like to see the uploaded documents for my individual students (Claudia).

  • As both a tutor and a student, I would want to have a cleaner view with button padding for documents view (Kasthurie).

  • As a tutor, I would like to see my latest doc on upload document page (Kasthurie).

  • Clean code, ex: delete unused code(Kasthurie + Claudia). (2)

  • Fixing issues in user_controller with Object Keys function. Use req.session instead. (Claudia)

  • Fixing Issues with ViewTutorCourse and ViewCoursePage. Filtering by Course id rather than name for security reasons and combining these two pages together.

  • UI fixes

    • Redirect the upload doc button on profile page to select course page, change it to one button (Kasthurie)
    • Fix padding on individual documents shared pages (Kasthurie)
    • Redirect message button to announcements page (Kasthurie)
    • Remove garbage button on the last column of all documents (Kasthurie)
    • Hide Document button when no documents are uploaded in doclist.js (Claudia)

Unit Tests:
Students:

https://github.com/compgirl123/TutifySoen490/blob/master/tutify/test/listofdocuments-tests-students.spec.js

Tutors:

https://github.com/compgirl123/TutifySoen490/blob/master/tutify/test/listofdocuments-tests-tutors.spec.js

Priority: High
Risk: Medium
Points: 13

@kasthurie kasthurie added this to the Iteration 8 (Release 2) milestone Jan 12, 2020
@compgirl123 compgirl123 changed the title Subtask: Delete uploaded documents Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students Jan 12, 2020
@compgirl123 compgirl123 changed the title Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students, Padding Fix Jan 13, 2020
@compgirl123 compgirl123 changed the title Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students, Padding Fix Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students, Add Latest Doc, Padding Fix Jan 13, 2020
@compgirl123 compgirl123 changed the title Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students, Add Latest Doc, Padding Fix Subtask: Delete uploaded documents, Tutor View Individual File Uploads to Students, View Latest Doc, Padding Fix Jan 13, 2020
compgirl123 added a commit that referenced this issue Jan 13, 2020
compgirl123 added a commit that referenced this issue Jan 16, 2020
kasthurie added a commit that referenced this issue Jan 17, 2020
PWatine pushed a commit that referenced this issue Jan 17, 2020
compgirl123 added a commit that referenced this issue Jan 19, 2020
@jaslatendresse jaslatendresse mentioned this issue Jan 20, 2020
11 tasks
compgirl123 added a commit that referenced this issue Jan 20, 2020
…or individual student page, courses page as well as all documents page
compgirl123 added a commit that referenced this issue Jan 20, 2020
kasthurie added a commit that referenced this issue Jan 21, 2020
compgirl123 added a commit that referenced this issue Jan 21, 2020
compgirl123 added a commit that referenced this issue Jan 21, 2020
@kasthurie
Copy link
Collaborator Author

Mockups of changes made upload doc feature and shared to courses/students:

Upload Doc and view list of docs uploaded

  • Lastly uploaded doc displayed on uploading page after its complete:

  • List of all documents uploaded (added buttons to share to courses/students and checkboxes to delete docs:

Sharing docs to specific courses

  • Once clicked on book icon next to a doc in all documents page, it will redirect to the courses page to select course to which tutor wants to upload the doc:

  • Once tutor selects a course, a pop up box appears to confirm the share:

Sharing docs to specific students

  • Once clicked on "people" icon next to a doc in all documents page, it will redirect to the list of students page to select students to which tutor wants to upload the doc:

  • Once tutor selects a student, a pop up box appears to confirm the share:

  • Student can see the doc shared on his profile (students/tutors can see docs shared to specific course done in the same way):

Delete Documents

  • Tutor can check checkboxes next to docs they want to delete and click the Delete button:

  • Once tutor clicks the delete button, a pop up box appears and asks the tutor to confirm the delete:

compgirl123 added a commit that referenced this issue Jan 21, 2020
… make upload document work on npm run build (deployment build)
compgirl123 added a commit that referenced this issue Jan 21, 2020
compgirl123 added a commit that referenced this issue Jan 21, 2020
compgirl123 added a commit that referenced this issue Jan 22, 2020
compgirl123 added a commit that referenced this issue Jan 25, 2020
…nt pages opens in same tab now not in different ones
compgirl123 added a commit that referenced this issue Jan 25, 2020
…ixed error with download page opening in same tab
@compgirl123
Copy link
Owner

Upload Document, Tutor can view Most Recent Document Uploaded:
recentdoc

@compgirl123
Copy link
Owner

On All Documents Page, Tutor has ability to delete many documents at once.
Deleting from here deletes from everywhere (from Courses Page and Student Page)
delete multiple docs all docs

@compgirl123
Copy link
Owner

On Each Specific Course Page, Tutor has ability to delete documents uploaded for the class. However, this would not delete the document everywhere so the tutor has ability to share the document to other classes or individually to select students

delete from courses

@compgirl123
Copy link
Owner

On the Individual Student Pages, Tutor has ability to delete documents shared to these particular students. Doing this does not delete the document from the application. The tutor thus has the ability to share these documents to other courses or other students.
individual document delete

@poojap12
Copy link
Collaborator

Good work. I like how we can either delete everything or just select classes and deleted from their sections. Signing off.

  • Pooja Patel

@sublime87
Copy link
Collaborator

great job

signing off

ross hodess

@TheMo28
Copy link
Collaborator

TheMo28 commented Jan 28, 2020

I like it. Deleting either documents for individual people or classes, or everyone, is good. Signing off.

-Mo Alawami

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants