Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for NVIDIA HPC SDK 25.1 #1503

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

jmuddnv
Copy link
Contributor

@jmuddnv jmuddnv commented Jan 23, 2025

Add HPC SDK 25.1 to bin/yaml/cpp.yaml

bin/yaml/cpp.yaml Show resolved Hide resolved
bin/yaml/cpp.yaml Show resolved Hide resolved
fetch:
- https://developer.download.nvidia.com/hpc-sdk/{version}/nvhpc_{year}_{dot_removed_version}_Linux_{arch}_cuda_{ctk_ver}.tar.gz nvhpc_sdk_{version}_{arch}.tar.gz
- name: x86_64_24_11
- name: x86_64_25_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you replacing an existing version? Please don't - keep the old version ? Or have we discussed this before? We typically keep all versions around as then we keep old links using older compilers working. Imagine if we only kept the most up-to-date clang and GCC only! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the source file for bin/yaml/cpp.yaml. There are two entries for 24.11 (I don't know how that happened) so I replaced the second one with 25.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh d'oh! thanks! I hadn't spotted; this is what happens when I only look at the github diff view.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for being patient with me.

@mattgodbolt mattgodbolt merged commit fdc0886 into compiler-explorer:main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants