Update gtest used to v1.15.2 #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 74.43% 74.57% +0.14%
==========================================
Files 8 8
Lines 3204 3214 +10
==========================================
+ Hits 2385 2397 +12
+ Misses 819 817 -2 |
mcbarton
force-pushed
the
update-gtest-to-version-v1.15.2
branch
2 times, most recently
from
8de0922 to
7c1b615
Compare
vgvassilev
reviewed
Oct 29, 2024
|
Please squash on merge. |
mcbarton
force-pushed
the
update-gtest-to-version-v1.15.2
branch
2 times, most recently
from
6ae2342 to
c60d845
Compare
mcbarton
force-pushed
the
update-gtest-to-version-v1.15.2
branch
from
823c24c to
54113ef
Compare
|
@vgvassilev This PR needs another review, as I had to take a different approach after your last review revealed an error in my previous approach. |
vgvassilev
reviewed
Nov 1, 2024
cmake/modules/GoogleTest.cmake
Outdated
| # issues due to [[maybe_unused]] in gtest) | ||
| set(EXTRA_GTEST_OPTS -DCMAKE_OSX_SYSROOT=${CMAKE_OSX_SYSROOT}) | ||
| set(CMAKE_CXX_FLAGS_TEMP_COPY ${CMAKE_CXX_FLAGS}) | ||
| string(REPLACE "-pedantic" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") |
There was a problem hiding this comment.
I am wondering if we need to propagate CMAKE_CXX_COMPILER to the CMAKE_ARGS. Alternatively in CMAKE_ARGS we can append -no-pedantic to disable the default mode.
|
@vgvassilev Rather than add |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will attempt to update the version of gtest we are using to version 1.15.2 .
Fixes #295