- 
                Notifications
    
You must be signed in to change notification settings  - Fork 36
 
Added pull_request_template.md #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   70.09%   75.08%   +4.98%     
==========================================
  Files          17       17              
  Lines         602      602              
  Branches       59       59              
==========================================
+ Hits          422      452      +30     
+ Misses        180      150      -30      | 
    
| 
           Well tough to comment on what sort of PR template we need (and if we need one) cause I've not seen any other xues stack have one :|  | 
    
| 
           @JohanMabille can you review this PR for me?  | 
    
| 
           @vgvassilev can you see if you can get this PR looked at?  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, and sorry for the late review! I think we can simplify it a bit, especially the latest section (checklist) adds too much "noise" to the template and could be removed.
| 
           @JohanMabille I have removed the checklist section and tests section. This should address all your comments. Are you happy with it now?  | 
    
| 
           Yep, thanks ;)  | 
    
This PR adds a basic pull request template to the repo. @vgvassilev @anutosh491 This PR is ready for review.