Refactoring some utilities

[anutosh491]

Few utilities that we use are already implemented and tested through xeus. So we can just get rid of them !

[anutosh491]

We should also be able to used the get_start_message function instead of the following

xeus-cpp/src/main.cpp

Lines 109 to 114 in 4745f72

	std::clog << "Starting xcpp kernel...\n\n"
	"If you want to connect to this kernel from an other client, just copy"
	" and paste the following content inside of a `kernel.json` file. And then run for example:\n\n"
	"# jupyter console --existing kernel.json\n\n"
	"kernel.json\n```\n{\n"
	" \"transport\": \""

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[anutosh491]

Looked straightforward but for some reason the test_xcpp_kernel.py test fails for some reason. Need to have a look into it

[anutosh491]

@vgvassilev @mcbarton I think this might have something to do with the patches in CppInterOp (y'all could help by confirming) cause through backtrace we get

error: error reading '/Users/runner/micromamba/envs/xeus-cpp/include': Is a directory
1 error generated.
Error: signal 11:
0   libxeus-cpp.0.5.0dev.dylib          0x000000010d492fbe _ZN4xcpp7handlerEi + 46
1   libsystem_platform.dylib            0x00007ff809df75ed _sigtramp + 29
2   ???                                 0x0000000000000004 0x0 + 4
3   libclangCppInterOp.18.1.dylib       0x0000000117a94620 _ZN5clang17IncrementalParserC2ERNS_11InterpreterENSt3__110unique_ptrINS_16CompilerInstanceENS3_14default_deleteIS5_EEEERN4llvm11LLVMContextERNS9_5ErrorE + 208
4   libclangCppInterOp.18.1.dylib       0x0000000117a97cca _ZN5clang11InterpreterC2ENSt3__110unique_ptrINS_16CompilerInstanceENS1_14default_deleteIS3_EEEERN4llvm5ErrorE + 346
5   libclangCppInterOp.18.1.dylib       0x0000000117a97f44 _ZN5clang11Interpreter6createENSt3__110unique_ptrINS_16CompilerInstanceENS1_14default_deleteIS3_EEEE + 84
6   libclangCppInterOp.18.1.dylib       0x0000000117a78e42 _ZN6compat22createClangInterpreterERNSt3__16vectorIPKcNS0_9allocatorIS3_EEEE + 386
7   libclangCppInterOp.18.1.dylib       0x0000000117a78a73 _ZN3Cpp11InterpreterC2EiPKPKcS2_RKNSt3__16vectorINS5_10shared_ptrIN5clang19ModuleFileExtensionEEENS5_9allocatorISA_EEEEPvb + 883
8   libclangCppInterOp.18.1.dylib       0x0000000117a6d3c9 CreateInterpreter + 1833
9   libxeus-cpp.0.5.0dev.dylib          0x000000010d456c44 _Z17createInterpreterRKNSt3__16vectorIPKcNS_9allocatorIS2_EEEE + 1492

[anutosh491]

Caught the bug here. Sadly I was looking at all places except the function I had changed (the stack trace didn't help and confused me even more).

It's an error with how xeus deals with extract_filename function, so have to fix that upstream.

[vgvassilev]

Why the nightly builds succeed then?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (1c0b74f) to head (0405251).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   80.72%   80.54%   -0.18%     
==========================================
  Files          19       19              
  Lines         970      956      -14     
  Branches       93       88       -5     
==========================================
- Hits          783      770      -13     
+ Misses        187      186       -1     

Files with missing lines	Coverage Δ
src/main.cpp	40.67% <100.00%> (ø)
src/xutils.cpp	75.00% <ø> (-5.44%)	⬇️

Files with missing lines	Coverage Δ
src/main.cpp	40.67% <100.00%> (ø)
src/xutils.cpp	75.00% <ø> (-5.44%)	⬇️

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[anutosh491]

This should be fixed after the next xeus release as jupyter-xeus/xeus#409 has been merged now !

[vgvassilev]

I'd keep the tests as upstream testing was a bit lacking last time I saw.

[anutosh491]

Ahhh no worries I made sure to add a test here (https://github.com/anutosh491/xeus/blob/13aea3049c99df566ae54061432b57b100747e91/test/test_unit_kernel.cpp#L56-L65)