Skip to content

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Dec 13, 2024

Description

Please include a summary of changes, motivation and context for this PR.

This PR copies the wasm build instructions to the online documentation

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@mcbarton mcbarton requested a review from anutosh491 December 13, 2024 09:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (0a3a75e) to head (0e7c667).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   80.80%   80.72%   -0.08%     
==========================================
  Files          19       19              
  Lines         974      970       -4     
  Branches       93       93              
==========================================
- Hits          787      783       -4     
  Misses        187      187              

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

@anutosh491
Copy link
Collaborator

Converting to draft

Once I make the changes required to get xeus-cpp-lite working on xeus-cpp, I shall also change the readme to express the same. We can then get those changes here and merge them too.

@anutosh491 anutosh491 marked this pull request as draft December 13, 2024 10:04
@mcbarton mcbarton marked this pull request as ready for review January 6, 2025 11:16
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging

@anutosh491 anutosh491 merged commit dc14222 into compiler-research:main Jan 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants