Change deploy runner to MacOS 15 #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
|
Not sure what's the purpose of this change ? |
|
@anutosh491 The purpose is simple that the MacOs runners are quicker, so when you want to deploy an updtated Jupyter Lite Site it happens quicker. |
Are there facts backing this ? Any documentation or something ? |
|
@anutosh491 Just look at the emscripten build times on CppInterOp as an example, or the osx builds vs Ubuntu build times. You'll notice that they are considerably shorter. |
anutosh491
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
The MacOS runners are faster. This will allow for faster deployment when new commits are made to the main branch.
Fixes # (issue)
Type of change
Please tick all options which are relevant.