Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xeus-cpp-lite to use emsdk 3.1.73 #246

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

anutosh491
Copy link
Collaborator

Description

Completes the update to 3.1.73 !

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (ba37f4f) to head (b0ca98b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Jan 29, 2025

This shows https://github.com/compiler-research/xeus-cpp/actions/runs/13029493410/job/36345418308?pr=246#step:6:38

That we use jupyterlite 0.5.0 yet, we need to use 0.5.1 here !
Maybe use it through pip ?

Needs a jupyterlite feedstock update otherwise
https://github.com/conda-forge/jupyterlite-core-feedstock

Raised a PR here conda-forge/jupyterlite-core-feedstock#48

@anutosh491 anutosh491 marked this pull request as draft January 29, 2025 10:44
@anutosh491 anutosh491 marked this pull request as ready for review January 29, 2025 13:18
@anutosh491
Copy link
Collaborator Author

Closing and Reopening to re-run jobs

@anutosh491 anutosh491 closed this Jan 29, 2025
@anutosh491 anutosh491 reopened this Jan 29, 2025
Copy link

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question. Otherwise looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants