Add test cases for xutils, xmagics_manager, xpreamble_manager and xbuffer #36
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
| } | ||
| } | ||
|
|
||
| TEST_SUITE("is_match_magics_manager") |
There was a problem hiding this comment.
@brauliorivas if I understand correctly you can improve this test to check xmagics_manager::apply with line magic instead. it would std::regex_search %python same as is_match but also check if the magic can be successfully applied(and possibly record any breaking of the magic commands)
There was a problem hiding this comment.
alright! I'll change it
There was a problem hiding this comment.
Hey @maximusron I'm working on this test case as you said but I'm having trouble with the apply function. If you have time, some help would be handy!
|
@anutosh491 @JohanMabille could you take a look at this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 49.32% 48.78% -0.54%
==========================================
Files 13 15 +2
Lines 742 783 +41
==========================================
+ Hits 366 382 +16
- Misses 376 401 +25 |
|
@brauliorivas, do you have any clue which part of the new changes breaks windows? |
I'm going to debug and try to solve the Windows issue. |
|
clang-tidy review says "All clean, LGTM! 👍" |
| xcpp::xmagics_manager* magics = new xcpp::xmagics_manager(); | ||
| manager.register_preamble(name, magics); | ||
|
|
||
| xcpp::xholder_preamble& result = manager.operator[](name); |
There was a problem hiding this comment.
We should probably annotate with XEUS_CPP_API the xholder_preamble class to fix the Windows failure...
There was a problem hiding this comment.
Alright, I've added this
There was a problem hiding this comment.
Hey @vgvassilev, thank you so much for the help, it worked!
|
clang-tidy review says "All clean, LGTM! 👍" |
I'd like to move forward and rely on a post-commit review here. |
4 participants
This pull request adds test cases for a few functions in the xcpp library.
should_print_versionTest Suite: Tests verify if the function correctly identifies the presence or absence of the--versionargument.build_interpreterTest Suite: A test case checks if the function returns a non-null pointer when valid arguments are passed.clone_magics_managerTest Suite: Tests ensure the function correctly returns a non-null pointer and that the cloned object matches the type of the original magics_manager.is_matchTest Suite: Verifies the function correctly identifies strings that match the regex pattern used inxmagics_manager.register_and_accessTest Suite: This test verifies the correct registration and access of axpreambleobject within thexpreamble_manager. It ensures that axpreambleobject can be registered with a name and subsequently accessed using the same name.xbufferTest Suite: The new test cases cover thexinput_buffer,xoutput_buffer, andxnullclasses, focusing on their interaction with various inputs and outputs. They verify the correct behavior of these classes when handling normal and edge cases, such as empty outputs, the correct invocation of callback functions, and the discarding of output byxnull.Currently, these new test cases were executed and successfully passed.