Skip to content

Conversation

@anutosh491
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (f622f5f) to head (b9258b0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files          20       20           
  Lines         845      845           
  Branches       87       87           
=======================================
  Hits          691      691           
  Misses        154      154           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Nov 7, 2025

So two problems from my previous PR #400

  1. the check_xeus_cpp executable is also responsible for the build and then the test. As we're building using emscripten, let's stick to emmake.

  2. We should switch when do we install and add node to our path.

Reason

configure: cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/runner/micromamba/envs/xeus-cpp-wasm-host -DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON -DCMAKE_FIND_ROOT_PATH=/home/runner/micromamba/envs/xeus-cpp-wasm-host -DSYSROOT_PATH=/home/runner/micromamba/envs/xeus-cpp-wasm-build/opt/emsdk/upstream/emscripten/cache/sysroot -DCMAKE_COMPILE_WARNING_AS_ERROR=ON .. -DCMAKE_TOOLCHAIN_FILE=/home/runner/micromamba/envs/xeus-cpp-wasm-build/opt/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=/home/runner/micromamba/envs/xeus-cpp-wasm-build/bin/node

Check the last line here : We're still using node from the xeus-cpp-wasm-build for the emulator. That's still node 16.

  • The CI for this PR has

configure: cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/runner/micromamba/envs/xeus-cpp-wasm-host -DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON -DCMAKE_FIND_ROOT_PATH=/home/runner/micromamba/envs/xeus-cpp-wasm-host -DSYSROOT_PATH=/home/runner/micromamba/envs/xeus-cpp-wasm-build/opt/emsdk/upstream/emscripten/cache/sysroot -DCMAKE_COMPILE_WARNING_AS_ERROR=ON .. -DCMAKE_TOOLCHAIN_FILE=/home/runner/micromamba/envs/xeus-cpp-wasm-build/opt/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake -DCMAKE_CROSSCOMPILING_EMULATOR=/home/runner/micromamba/envs/node-env/bin/node

So now we're correctly overriding the node we want to use for the emulator for building/testing.

@mcbarton mcbarton merged commit 6117076 into compiler-research:main Nov 7, 2025
16 checks passed
@anutosh491 anutosh491 deleted the fix_check_xeus_cpp branch November 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants