Skip to content

Conversation

tharun571
Copy link
Contributor

No description provided.

@aaronj0
Copy link

aaronj0 commented Mar 19, 2024

@vgvassilev could you approve the CI builds on this PR? Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.55%. Comparing base (f33ae90) to head (d588ef0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   48.78%   49.55%   +0.76%     
==========================================
  Files          15       15              
  Lines         783      783              
==========================================
+ Hits          382      388       +6     
+ Misses        401      395       -6     

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Contributor

@tharun571, could you rebase this PR?

@tharun571
Copy link
Contributor Author

@vgvassilev rebased.

@tharun571 tharun571 changed the title Add test cases for xutils, xparser Add test cases for xparser Mar 19, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 2dbe8da into compiler-research:main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants