-
Notifications
You must be signed in to change notification settings - Fork 36
Update ci Ubuntu to 24.04 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci Ubuntu to 24.04 #74
Conversation
Converting to draft since although Ubuntu 24.04 are listed as available, the workflow isn't able to find a runner. At least not on a fast timescale. |
@vgvassilev @alexander-penev Can one of you manually reactivate the workflow? The runners should be available now according to this blog post https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 53.66% 53.66%
=======================================
Files 15 15
Lines 600 600
Branches 0 59 +59
=======================================
Hits 322 322
Misses 278 278
|
d7447eb
to
118b2e2
Compare
clang-tidy review says "All clean, LGTM! 👍" |
@vgvassilev @alexander-penev can one of you merge this PR now the new runners are available? |
@anutosh491 @JohanMabille can one of you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@anutosh491 Thanks for reviewing and approving so fast. Are you able to merge the PR? |
This PR updates the Ubuntu used in the ci to the latest version (24.04). The random added line is to check that I didn't break the clang tidy ci by updating to a newer Ubuntu.