Skip to content

Conversation

mcbarton
Copy link
Collaborator

This PR updates the Ubuntu used in the ci to the latest version (24.04). The random added line is to check that I didn't break the clang tidy ci by updating to a newer Ubuntu.

@mcbarton mcbarton marked this pull request as draft May 10, 2024 18:14
@mcbarton
Copy link
Collaborator Author

mcbarton commented May 10, 2024

Converting to draft since although Ubuntu 24.04 are listed as available, the workflow isn't able to find a runner. At least not on a fast timescale.

@mcbarton
Copy link
Collaborator Author

@vgvassilev @alexander-penev Can one of you manually reactivate the workflow? The runners should be available now according to this blog post https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.66%. Comparing base (aa77879) to head (118b2e2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   53.66%   53.66%           
=======================================
  Files          15       15           
  Lines         600      600           
  Branches        0       59   +59     
=======================================
  Hits          322      322           
  Misses        278      278           
Files Coverage Δ
src/xutils.cpp 78.57% <ø> (ø)
Files Coverage Δ
src/xutils.cpp 78.57% <ø> (ø)

@mcbarton mcbarton marked this pull request as ready for review May 15, 2024 06:42
@mcbarton mcbarton force-pushed the update-to-Ubuntu-24.04 branch from d7447eb to 118b2e2 Compare May 15, 2024 06:42
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator Author

@vgvassilev @alexander-penev can one of you merge this PR now the new runners are available?

@mcbarton
Copy link
Collaborator Author

@anutosh491 @JohanMabille can one of you review this PR?

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcbarton
Copy link
Collaborator Author

@anutosh491 Thanks for reviewing and approving so fast. Are you able to merge the PR?

@vgvassilev vgvassilev merged commit f20af56 into compiler-research:main May 16, 2024
@mcbarton mcbarton deleted the update-to-Ubuntu-24.04 branch May 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants