Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Buttons + Create Style Guide page #98

Merged
merged 7 commits into from
Jul 28, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 27, 2023

part of #37
part of #49

Updates the fonts/colors/styles of the main style guide's buttons

What this PR does

Buttons

  • btn btn-primary
  • btn btn-primary disabled
  • btn btn-outline-primary
  • btn btn-outline-primary disabled
image
  • btn btn-primary in focus
image

Style Guide at /styles

image image

@machikoyasuda machikoyasuda changed the title Refactor: Use btn, btn-primary, btn-outline-primary Bootstrap CSS variables Refactor: Buttons + Create Style Guide page Jul 27, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review July 27, 2023 22:01
@machikoyasuda machikoyasuda self-assigned this Jul 27, 2023
@machikoyasuda machikoyasuda linked an issue Jul 27, 2023 that may be closed by this pull request
@machikoyasuda machikoyasuda merged commit c8bfe28 into feat/37-colors-only Jul 28, 2023
@machikoyasuda machikoyasuda deleted the feat/37-refactor-buttons branch July 28, 2023 00:04
@thekaveman
Copy link
Member

@machikoyasuda No one reviewed this before it was merged. #49 is not on our list of priorities for this website right now.

@machikoyasuda
Copy link
Member Author

This was just merged into my other PR. Not into main.

@angela-tran angela-tran removed this from the Careers & Job Page (phase 1) milestone Aug 11, 2023
@angela-tran
Copy link
Member

Removing from Careers & Jobs Page (phase 1) milestone since these changes got moved to being a part of #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants