Feat: improve proof-of-concept app #116
Draft
+12,457
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
lalver1
force-pushed
the
feat/app-stations
branch
from
b32158d to
31a45b5
Compare
lalver1
force-pushed
the
feat/app-stations
branch
4 times, most recently
from
271fa52 to
394f3da
Compare
lalver1
commented
Jun 12, 2025
| <h2>Map</h2> | ||
| <div class="row" style="min-height: 450px;"> | ||
| <div class="col-lg-12 border"> | ||
| <iframe class="streamlit-app" src="{{ streamlit_host }}/stations--stations?embed=true&district_number={{ current_district.number }}"> |
There was a problem hiding this comment.
rename class to streamlit-service
Realized that the custom streamlit-app class was not necessary since it can be replaced by Bootstrap's w-100 h-100.
lalver1
commented
Jun 12, 2025
pems/core/context_processors.py
Outdated
| def streamlit_host(request): | ||
| """Context processor to add the Streamlit host URL part to the context.""" | ||
|
|
||
| return {"streamlit_host": settings.STREAMLIT_HOST} |
There was a problem hiding this comment.
consider top-level streamlit context
lalver1
commented
Jun 12, 2025
pems/settings.py
Outdated
|
|
||
| # Streamlit settings | ||
| STREAMLIT_LOCAL_PORT = os.environ.get("STREAMLIT_LOCAL_PORT", "") | ||
| STREAMLIT_HOST = os.environ.get("STREAMLIT_HOST", f"http://localhost:{STREAMLIT_LOCAL_PORT}") |
There was a problem hiding this comment.
collapse these 2 variables to 1
lalver1
commented
Jun 12, 2025
pems/static/css/styles.css
Outdated
| @@ -10,3 +10,8 @@ header { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .streamlit-app { | |||
There was a problem hiding this comment.
is there a class in Bootstrap already that already sets these 2 properties? if so, use that one
lalver1
commented
Jun 12, 2025
| @@ -35,6 +35,8 @@ EXPOSE 8501 | |||
|
|
|||
| COPY streamlit_app streamlit_app | |||
|
|
|||
| COPY .streamlit .streamlit | |||
There was a problem hiding this comment.
move this to before COPY streamlit_app streamlit_app to take advantage of layer caching
the District Stations Streamlit app is a simple proof-of-concept that displays the traffic data collection stations in a district.
the django and streamlit apps are now wired up in a way that works both for a local dev environment as well as a Cloud deployment.
since the web and streamlit services run on the same load balancer in AWS, the http path defined in the manifest of each service must be different from each other. the http path of the streamlit service (streamlit_service) is also passed to the streamlit run command in the entrypoint.sh script. also, the healthcheck path must be defined in the manifest so that the service does not continually restart.
this setup was causing an error when deploying to AWS since the Django pems app resides in a different container. when running a local debugger though, this error was not present since the local dev container does have the pems app. since at this moment we are not using Django models in the streamlit app, we are removing this ability.
copy the .streamlit directory into the streamlit service's image so that the streamlit configuration is available to the container. before, the configuration was only available to the local dev container.
lalver1
force-pushed
the
feat/app-stations
branch
from
d2549eb to
56f7ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Adds the
stationsapp to the repo (before it was only a local branch) and wires up django and streamlit in an environment-dependent way so that the proof-of-conceptdistrictsapp can run both locally and in the Cloud.Currently this branch is on top ofci/cloud-infrabut it will be rebased onmainonce PR #111 is merged.Notes
Originally, the
streamlitservice was defined as a copilotBackend Service. For an initial proof-of-concept this is not a convenient service type since the service is unreachable from the internet (recall that thewebservice embedsstreamlitin an iframe, sostreamlitneeds to be reachable from the internet). For this PR, we will changestreamlitto aLoad Balanced Web Service. As we get closer to production, the architecture will likely change to:webto act as a reverse proxyiframes inwebwill point to a path inwebbut this path will be set up in thengingxconfiguration to forward any requests tostreamlitover the private networkstreamlitin a private network (back toBackend Service) and configure it to deny all incoming traffic except for requests from the private IP address ofweb.