Reading doc and some discussion

[sunxd3]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

[github-actions]

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬────────┬─────────┬─────────────┬─────────┐
│                      Label │  Tapir │  Zygote │ ReverseDiff │  Enzyme │
│                     String │ String │  String │      String │  String │
├────────────────────────────┼────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │  117.0 │   0.775 │        4.84 │    1.71 │
│                  _sum_1000 │    8.0 │  1300.0 │        32.9 │  0.0841 │
│               sum_sin_1000 │   3.04 │     1.6 │        10.8 │   0.979 │
│              _sum_sin_1000 │   3.35 │   294.0 │        16.3 │    1.39 │
│                   kron_sum │   78.1 │    3.44 │       200.0 │    8.14 │
│              kron_view_sum │   88.1 │    11.1 │       243.0 │    8.36 │
│      naive_map_sin_cos_exp │   4.13 │ missing │        8.63 │    2.76 │
│            map_sin_cos_exp │   4.61 │    1.74 │        7.24 │    3.35 │
│      broadcast_sin_cos_exp │   4.56 │     2.6 │        1.64 │    2.78 │
│                 simple_mlp │   8.88 │    3.08 │        12.0 │    3.13 │
│                     gp_lml │   16.4 │    4.48 │     missing │ missing │
│ turing_broadcast_benchmark │   8.44 │ missing │        30.7 │ missing │
└────────────────────────────┴────────┴─────────┴─────────────┴─────────┘

[sunxd3]

Some questions:

https://github.com/compintell/Tapir.jl/blob/5d0e086017e070d4132d8852c15a2ad3e23684f2/docs/src/mathematical_interpretation.md?plain=1#L125-L127
should s be included in this?

https://github.com/compintell/Tapir.jl/blob/5d0e086017e070d4132d8852c15a2ad3e23684f2/docs/src/mathematical_interpretation.md?plain=1#L173-L179
these are not quite obvious to me

https://github.com/compintell/Tapir.jl/blob/5d0e086017e070d4132d8852c15a2ad3e23684f2/docs/src/mathematical_interpretation.md?plain=1#L310C1-L311C49
any update to this?

https://github.com/compintell/Tapir.jl/blob/5d0e086017e070d4132d8852c15a2ad3e23684f2/docs/src/mathematical_interpretation.md?plain=1#L343-L355
maybe mention this is for demonstration, in the sense that Tapir will generate this automatically? (if I understand right)

[willtebbutt]

Basically happy with your proposals -- only a couple of things I disagree with.

[sunxd3]

done

[willtebbutt]

Regarding your questions:

should s be included in this?

Almost certainly. We should fix this. I think I re-worked the example, but must have forgotten to update this bit.

these are not quite obvious to me

Could you expand one which bit is not clear?

any update to this?

Not yet, although I really need to push it forward. I think this is also how JAX thinks about these kinds of objects, so I might take a closer look at what they do.

maybe mention this is for demonstration, in the sense that Tapir will generate this automatically? (if I understand right)

Great point. Would you mind adding something to this effect?

[sunxd3]

sure, will update these slightly later

[willtebbutt]

Thanks for the updated items -- I think we're nearly there!

[willtebbutt]

This is a really helpful PR, thanks! Please feel free to merge - no need to tag a release since it just modifies the docs.