Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preadv & pwritev support #101

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Add preadv & pwritev support #101

merged 13 commits into from
Oct 19, 2023

Conversation

Berrysoft
Copy link
Member

@Berrysoft Berrysoft commented Oct 18, 2023 •
edited
Loading

And add default impl for *_vectored_at.

Closes #92

George-Miao
George-Miao requested changes Oct 18, 2023
View reviewed changes
compio-driver/src/lib.rs Show resolved Hide resolved
compio-io/src/read/ext.rs Show resolved Hide resolved
@George-Miao George-Miao added the enhancement New feature or request label Oct 18, 2023
George-Miao
George-Miao approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 2bd90dd into compio-rs:master Oct 19, 2023
11 checks passed
@Berrysoft Berrysoft deleted the dev/pv branch October 19, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use u64 instead of usize in *_at methods and ops
2 participants
@Berrysoft @George-Miao