Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async DNS resolve #106

Merged
merged 17 commits into from
Oct 20, 2023
Merged

Async DNS resolve #106

merged 17 commits into from
Oct 20, 2023

Conversation

Berrysoft
Copy link
Member

@Berrysoft Berrysoft commented Oct 19, 2023 •
edited
Loading

Closes #98

  • Windows
  • Linux glibc
  • Unix

@Berrysoft Berrysoft marked this pull request as ready for review October 19, 2023 18:11
@Berrysoft
Copy link
Member Author

I choose to use SIGEV_THREAD instead of SIGEV_SIGNAL because it is difficult to cleanup the signal handlers.

@Berrysoft Berrysoft self-assigned this Oct 19, 2023
@Berrysoft Berrysoft added the enhancement New feature or request label Oct 19, 2023
Berrysoft
Berrysoft commented Oct 19, 2023
View reviewed changes
Copy link
Member Author

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also use Event on Windows.

compio-driver/src/iocp/op.rs Outdated Show resolved Hide resolved
George-Miao
George-Miao requested changes Oct 20, 2023
View reviewed changes
compio-net/src/lib.rs Show resolved Hide resolved
compio-net/src/lib.rs Outdated Show resolved Hide resolved
compio-net/src/lib.rs Outdated Show resolved Hide resolved
George-Miao
George-Miao approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit e56a310 into compio-rs:master Oct 20, 2023
11 checks passed
@Berrysoft Berrysoft deleted the dev/async-resolve branch October 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

@bdbai bdbai Awaiting requested review from bdbai

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async DNS resolve
2 participants
@Berrysoft @George-Miao