feat(driver): fusion driver #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
George-Miao
added
enhancement
Berrysoft
reviewed
Oct 20, 2023
nazar-pc
reviewed
Oct 23, 2023
| @@ -10,7 +10,7 @@ | |||
| not(feature = "io-uring"), | |||
| not(feature = "polling") | |||
| ))] | |||
| compile_error!("You must choose one of these features: [\"io-uring\", \"polling\"]"); | |||
| compile_error!("You must choose at leaset one of these features: [\"io-uring\", \"polling\"]"); | |||
There was a problem hiding this comment.
Suggested change
| compile_error!("You must choose at leaset one of these features: [\"io-uring\", \"polling\"]"); | |
| compile_error!("You must choose at least one of these features: [\"io-uring\", \"polling\"]"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added fusion driver, which will be enabled when both
io-uringandpollingare enabled, and will determine which to use during runtime.However, this does bring some overhead throughout the lifetime of the driver:
io-uringandpollingimplementations.@nazar-pc what do you think?
Closes #105