Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HTTP client #127

Merged
merged 46 commits into from
Nov 11, 2023
Merged

feat: HTTP client #127

merged 46 commits into from
Nov 11, 2023

Conversation

Berrysoft
Copy link
Member

@Berrysoft Berrysoft commented Oct 25, 2023 •
edited
Loading

This first PR adds a simple HTTP client with some found bug fixes.

Cookies support and compression are in the following PRs.

@Berrysoft Berrysoft self-assigned this Oct 25, 2023
@George-Miao George-Miao added enhancement New feature or request package: http labels Oct 26, 2023
@Berrysoft Berrysoft marked this pull request as ready for review November 6, 2023 16:42
@Berrysoft Berrysoft marked this pull request as draft November 7, 2023 12:03
@Berrysoft Berrysoft marked this pull request as draft November 10, 2023 09:07
@Berrysoft Berrysoft marked this pull request as ready for review November 10, 2023 10:32
@Berrysoft
Copy link
Member Author

This PR proposals two crate: compio-http and compio-http-client. The first one provides mid-level hyper services, for both client and server; the second one provides a reqwest-like high level HTTP client. This design provides possibility to author a web framework based on hyper, and most flexibility for users who wants to author their own client and server.

George-Miao
George-Miao requested changes Nov 11, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next PR's, please consider limit the change within the scope of crate. E.g. fix for nightly feature and modifications to io/tls should be in their own PRs. And existing PR's can rebase upon merged master.

compio-http-client/src/client.rs Outdated Show resolved Hide resolved
compio-http/Cargo.toml Show resolved Hide resolved
compio-http-client/Cargo.toml Show resolved Hide resolved
compio-http/Cargo.toml Show resolved Hide resolved
George-Miao
George-Miao approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 368fddb into compio-rs:master Nov 11, 2023
0 of 11 checks passed
@Berrysoft Berrysoft deleted the dev/http-client branch November 11, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berrysoft @George-Miao @ho-229