Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fs,driver): add async metadata #170

Merged
merged 20 commits into from
Jan 2, 2024
Merged

feat(fs,driver): add async metadata #170

merged 20 commits into from
Jan 2, 2024

Conversation

Berrysoft
Copy link
Member

It's tough to implement all these methods manually:(

@Berrysoft Berrysoft added enhancement New feature or request package: fs Related to compio-fs package: driver Related to compio-driver labels Dec 7, 2023
@Berrysoft Berrysoft self-assigned this Dec 7, 2023
@Berrysoft Berrysoft marked this pull request as draft December 8, 2023 11:25
@Berrysoft Berrysoft marked this pull request as ready for review December 8, 2023 13:11
@Berrysoft
Copy link
Member Author

Blocking: rust-lang/rust#118795

@Berrysoft
Copy link
Member Author

We should not impl MetadataExt on Windows because the rust team don't want us to do that:(

@Berrysoft Berrysoft marked this pull request as draft December 11, 2023 07:09
@Berrysoft Berrysoft marked this pull request as ready for review December 11, 2023 10:58
George-Miao
George-Miao requested changes Dec 26, 2023
View reviewed changes
compio-driver/src/iocp/op.rs Show resolved Hide resolved
compio-fs/src/metadata/mod.rs Outdated Show resolved Hide resolved
George-Miao
George-Miao approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 6b8f7ed into compio-rs:master Jan 2, 2024
11 checks passed
@Berrysoft Berrysoft deleted the dev/statx branch January 2, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request package: driver Related to compio-driver package: fs Related to compio-fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berrysoft @George-Miao