Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): async connect unix stream #212

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Berrysoft
Copy link
Member

Previously we failed because, on Windows, ConnectEx requires a bound socket. We can bind it to an empty address.

@Berrysoft Berrysoft added enhancement New feature or request package: net Related to compio-net labels Feb 19, 2024
@Berrysoft Berrysoft added this to the v0.9 release milestone Feb 19, 2024
@Berrysoft Berrysoft self-assigned this Feb 19, 2024
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 376000c into compio-rs:master Mar 4, 2024
27 checks passed
@Berrysoft Berrysoft deleted the fix/unix-connect branch March 4, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package: net Related to compio-net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants