-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): a runtime hook API design #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berrysoft
added
enhancement
New feature or request
package: runtime
Related to compio-runtime
labels
Feb 25, 2024
Berrysoft
force-pushed
the
dev/runtime-hook
branch
from
February 25, 2024 09:24
6de972a
to
f1a11ec
Compare
Berrysoft
force-pushed
the
dev/runtime-hook
branch
from
February 26, 2024 07:01
647aac5
to
1f6cc75
Compare
George-Miao
reviewed
Mar 4, 2024
George-Miao
reviewed
Mar 4, 2024
George-Miao
reviewed
Mar 4, 2024
George-Miao
reviewed
Mar 4, 2024
George-Miao
reviewed
Mar 4, 2024
Berrysoft
force-pushed
the
dev/runtime-hook
branch
from
March 4, 2024 06:27
d55da8e
to
be7f7b6
Compare
George-Miao
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests added to show how this hook could be used.