Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(driver): remove OpenFile & stat ops for Windows #228

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

Berrysoft
Copy link
Member

These ops are not mature, and the user should use the std ones for safety and stability.

Also a fix for unix that the fd should live long enough when using spawn_blocking.

@Berrysoft Berrysoft added bug Something isn't working driver: IOCP About the IOCP driver driver: polling About the polling driver package: fs Related to compio-fs package: driver Related to compio-driver refactor Refactoring existing code labels Mar 22, 2024
@Berrysoft Berrysoft self-assigned this Mar 22, 2024
@Berrysoft Berrysoft marked this pull request as ready for review March 22, 2024 17:21
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit a3c9d27 into compio-rs:master Mar 22, 2024
29 checks passed
@Berrysoft Berrysoft deleted the refactor/op-cleanup branch March 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver: IOCP About the IOCP driver driver: polling About the polling driver package: driver Related to compio-driver package: fs Related to compio-fs refactor Refactoring existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants